Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: pkg/compiler/lib/src/resolution/send_resolver.dart

Issue 1971193002: Patches to support Dart VM patch files in dart2js. (Closed) Base URL: sso://user/ahe/dart-sdk@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/resolution/resolution.dart ('k') | pkg/compiler/lib/src/resolution/type_resolver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/resolution/send_resolver.dart
diff --git a/pkg/compiler/lib/src/resolution/send_resolver.dart b/pkg/compiler/lib/src/resolution/send_resolver.dart
index 7ef2a8623d4479392decc12b5123ab2f15ba2fba..b8b056318195f82c7cb48ee417560332ec834f42 100644
--- a/pkg/compiler/lib/src/resolution/send_resolver.dart
+++ b/pkg/compiler/lib/src/resolution/send_resolver.dart
@@ -59,7 +59,8 @@ class ConstructorDeclStructure<R, A> extends DeclStructure<R, A> {
class RedirectingFactoryConstructorDeclStructure<R, A>
extends DeclStructure<R, A> {
- InterfaceType redirectionTargetType;
+ // TODO(ahe): Construct invalid something instead.
+ DartType redirectionTargetType;
ConstructorElement redirectionTarget;
RedirectingFactoryConstructorDeclStructure(ConstructorElement constructor,
@@ -224,12 +225,15 @@ abstract class DeclarationResolverMixin {
bool constructorInvocationSeen = false;
if (list != null) {
for (Node initializer in list) {
- InitializerStructure structure =
- computeInitializerStructure(initializer);
- if (structure.isConstructorInvoke) {
- constructorInvocationSeen = true;
+ if (elements[initializer] != null) {
+ // TODO(ahe): Create erroneous structure.
+ InitializerStructure structure =
+ computeInitializerStructure(initializer);
+ if (structure.isConstructorInvoke) {
+ constructorInvocationSeen = true;
+ }
+ initializers.add(structure);
}
- initializers.add(structure);
}
}
if (!constructorInvocationSeen) {
« no previous file with comments | « pkg/compiler/lib/src/resolution/resolution.dart ('k') | pkg/compiler/lib/src/resolution/type_resolver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698