Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1971163002: [turbofan] Fix optimized lowering of Math.imul. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix optimized lowering of Math.imul. We eagerly inserted Int32Mul for Math.imul during builtin lowering and messed up with the types, which confused the representation selection. This adds a proper NumberImul operator, and fixes the builtin reducer to do the right thing according to the spec. R=mstarzinger@chromium.org BUG=v8:5006 LOG=n Committed: https://crrev.com/fa7460adbcc544dcd1483999b553e0cdcab43b51 Cr-Commit-Position: refs/heads/master@{#36219}

Patch Set 1 #

Patch Set 2 : Fix unittests. Reorder as pointed out by Michi. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -18 lines) Patch
M src/compiler/js-builtin-reducer.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M src/compiler/opcodes.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/representation-change.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-5006.js View 1 chunk +4 lines, -10 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Benedikt Meurer
4 years, 7 months ago (2016-05-12 12:57:08 UTC) #1
Benedikt Meurer
Hey Michi, Next bug fix. Please take a look. Thanks, Benedikt
4 years, 7 months ago (2016-05-12 12:58:10 UTC) #2
Michael Starzinger
LGTM.
4 years, 7 months ago (2016-05-12 13:04:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971163002/1
4 years, 7 months ago (2016-05-12 13:10:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/5686) v8_linux_dbg_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 7 months ago (2016-05-12 13:33:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971163002/20001
4 years, 7 months ago (2016-05-12 18:04:17 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-12 18:42:21 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 18:43:39 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fa7460adbcc544dcd1483999b553e0cdcab43b51
Cr-Commit-Position: refs/heads/master@{#36219}

Powered by Google App Engine
This is Rietveld 408576698