Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/compiler/typer.cc

Issue 1971163002: [turbofan] Fix optimized lowering of Math.imul. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix unittests. Reorder as pointed out by Michi. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/simplified-operator.cc ('k') | src/compiler/verifier.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/typer.h" 5 #include "src/compiler/typer.h"
6 6
7 #include "src/base/flags.h" 7 #include "src/base/flags.h"
8 #include "src/bootstrapper.h" 8 #include "src/bootstrapper.h"
9 #include "src/compilation-dependencies.h" 9 #include "src/compilation-dependencies.h"
10 #include "src/compiler/common-operator.h" 10 #include "src/compiler/common-operator.h"
(...skipping 1727 matching lines...) Expand 10 before | Expand all | Expand 10 after
1738 1738
1739 Type* Typer::Visitor::TypeNumberShiftRight(Node* node) { 1739 Type* Typer::Visitor::TypeNumberShiftRight(Node* node) {
1740 return Type::Signed32(); 1740 return Type::Signed32();
1741 } 1741 }
1742 1742
1743 1743
1744 Type* Typer::Visitor::TypeNumberShiftRightLogical(Node* node) { 1744 Type* Typer::Visitor::TypeNumberShiftRightLogical(Node* node) {
1745 return Type::Unsigned32(); 1745 return Type::Unsigned32();
1746 } 1746 }
1747 1747
1748 Type* Typer::Visitor::TypeNumberImul(Node* node) { return Type::Signed32(); }
1749
1748 Type* Typer::Visitor::TypeNumberClz32(Node* node) { 1750 Type* Typer::Visitor::TypeNumberClz32(Node* node) {
1749 return typer_->cache_.kZeroToThirtyTwo; 1751 return typer_->cache_.kZeroToThirtyTwo;
1750 } 1752 }
1751 1753
1752 Type* Typer::Visitor::TypeNumberCeil(Node* node) { 1754 Type* Typer::Visitor::TypeNumberCeil(Node* node) {
1753 return TypeUnaryOp(node, NumberCeil); 1755 return TypeUnaryOp(node, NumberCeil);
1754 } 1756 }
1755 1757
1756 Type* Typer::Visitor::TypeNumberFloor(Node* node) { 1758 Type* Typer::Visitor::TypeNumberFloor(Node* node) {
1757 return TypeUnaryOp(node, NumberFloor); 1759 return TypeUnaryOp(node, NumberFloor);
(...skipping 813 matching lines...) Expand 10 before | Expand all | Expand 10 after
2571 } 2573 }
2572 if (Type::IsInteger(*value)) { 2574 if (Type::IsInteger(*value)) {
2573 return Type::Range(value->Number(), value->Number(), zone()); 2575 return Type::Range(value->Number(), value->Number(), zone());
2574 } 2576 }
2575 return Type::Constant(value, zone()); 2577 return Type::Constant(value, zone());
2576 } 2578 }
2577 2579
2578 } // namespace compiler 2580 } // namespace compiler
2579 } // namespace internal 2581 } // namespace internal
2580 } // namespace v8 2582 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/simplified-operator.cc ('k') | src/compiler/verifier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698