Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: src/compiler/verifier.cc

Issue 1971163002: [turbofan] Fix optimized lowering of Math.imul. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix unittests. Reorder as pointed out by Michi. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | test/mjsunit/regress/regress-5006.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/verifier.cc
diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc
index a788503473713c265078288116c2549db4d13c08..a8177a48573d44daec0ece02384b12632ab82c32 100644
--- a/src/compiler/verifier.cc
+++ b/src/compiler/verifier.cc
@@ -700,6 +700,12 @@ void Verifier::Visitor::Check(Node* node) {
CheckValueInputIs(node, 1, Type::Unsigned32());
CheckUpperIs(node, Type::Unsigned32());
break;
+ case IrOpcode::kNumberImul:
+ // (Unsigned32, Unsigned32) -> Signed32
+ CheckValueInputIs(node, 0, Type::Unsigned32());
+ CheckValueInputIs(node, 1, Type::Unsigned32());
+ CheckUpperIs(node, Type::Signed32());
+ break;
case IrOpcode::kNumberClz32:
// Unsigned32 -> Unsigned32
CheckValueInputIs(node, 0, Type::Unsigned32());
« no previous file with comments | « src/compiler/typer.cc ('k') | test/mjsunit/regress/regress-5006.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698