DevTools: Fix wrong is-array-like detection when logging in console.

DevTools: Fix wrong is-array-like detection when logging in console.

1) Functions should not be logged as array-like objects.
2) Log DOMTokenList as array in console, like we already do for HTMLCollection and NodeList.

BUG=350644
R=pfeldman

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169012

[pfeldman, 2014-03-12 11:32:12]

lgtm

[aandrey, 2014-03-12 12:02:06]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-03-12 12:02:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aandrey@chromium.org/197073004/1

[commit-bot: I haz the power, 2014-03-12 12:02:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-12 12:02:23]

Failed to apply patch for
LayoutTests/inspector/console/console-format-expected.txt:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/inspector/console/console-format-expected.txt
  Hunk #1 succeeded at 66 (offset -1 lines).
  Hunk #2 FAILED at 131.
  Hunk #3 succeeded at 198 (offset -2 lines).
  1 out of 3 hunks FAILED -- saving rejects to file
LayoutTests/inspector/console/console-format-expected.txt.rej

Patch:       LayoutTests/inspector/console/console-format-expected.txt
Index: LayoutTests/inspector/console/console-format-expected.txt
diff --git a/LayoutTests/inspector/console/console-format-expected.txt
b/LayoutTests/inspector/console/console-format-expected.txt
index
201862bdd820ad86033c0ef82dde33ae3abf772a..e40622d4f007e09ba78fb38a9248bfc361d89155
100644
--- a/LayoutTests/inspector/console/console-format-expected.txt
+++ b/LayoutTests/inspector/console/console-format-expected.txt
@@ -67,6 +67,8 @@ CONSOLE MESSAGE: line 12: function Object() { [native code] }
 CONSOLE MESSAGE: line 13: function Object() { [native code] }
 CONSOLE MESSAGE: line 12: [object Object]
 CONSOLE MESSAGE: line 13: [object Object]
+CONSOLE MESSAGE: line 12: function () {}
+CONSOLE MESSAGE: line 13: function () {}
 Tests that console logging dumps proper messages.
 
  Array[10]0: "test"1: "test2"4: "test4"foo: Objectlength: 10__proto__: Array[0]
console-format.html:26
@@ -129,7 +131,7 @@ undefined console-format.html:12
 [undefined] console-format.html:13
 globals[12]
 undefined
-Attr.specified is deprecated. Its value is always true. VM:437
+Attr.specified is deprecated. Its value is always true. VM:461
 attr="" console-format.html:12
 [attr]0: attrlength: 1__proto__: Array[0] console-format.html:13
 globals[13]
@@ -198,4 +200,8 @@ Object {} console-format.html:12
 [Object]0: Objectlength: 1__proto__: Array[0] console-format.html:13
 globals[29]
 Object {}
+function () {} console-format.html:12
+[function]0: function () {}length: 1__proto__: Array[0] console-format.html:13
+globals[30]
+function () {} console-format.html:55

[aandrey, 2014-03-12 12:09:22]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-03-12 12:09:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aandrey@chromium.org/197073004/20001

[commit-bot: I haz the power, 2014-03-12 13:16:36]

Change committed as 169012