LayoutTests/inspector/console/console-format-collections.html - Issue 197073004: DevTools: Fix wrong is-array-like detection when logging in console.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/inspector/console/console-format-collections.html

Issue 197073004: DevTools: Fix wrong is-array-like detection when logging in console. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebased Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/inspector/console/console-format-collections.html

diff --git a/LayoutTests/inspector/console/console-format-collections.html b/LayoutTests/inspector/console/console-format-collections.html

index 964b43f98db96b1a2d4b685ab180a4fa1abdb2d8..c354939072bf1c75c0576604d897dbdd5f16c074 100644

--- a/LayoutTests/inspector/console/console-format-collections.html

+++ b/LayoutTests/inspector/console/console-format-collections.html

@@ -49,6 +49,10 @@ function logToConsole()

return arguments;

}

console.log(generateArguments(1, "2"));

+ // DOMTokenList

+ var div = document.getElementsByTagName("div")[0];

+ console.log(div.classList);

}

function onload()

@@ -59,12 +63,12 @@ function onload()

function NonArrayWithLength()

{

- this.keys=[];

+ this.keys = [];

}

NonArrayWithLength.prototype.__defineGetter__("length", function()

{

- console.log(".length should not be called");

+ console.log("FAIL: 'length' should not be called");

return this.keys.length;

});

@@ -83,9 +87,9 @@ function test()

<p>

-Tests that console nicely formats HTML Collections and NodeLists.

+Tests that console nicely formats HTML Collections, NodeLists and DOMTokenLists.

</p>

-<div style="display:none">

+<div style="display:none" class="c1 c2 c3">