Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Side by Side Diff: LayoutTests/inspector/console/console-format.html

Issue 197073004: DevTools: Fix wrong is-array-like detection when logging in console. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebased Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | LayoutTests/inspector/console/console-format-collections.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <html> 1 <html>
2 <head> 2 <head>
3 <script src="../../http/tests/inspector/inspector-test.js"></script> 3 <script src="../../http/tests/inspector/inspector-test.js"></script>
4 <script src="../../http/tests/inspector/console-test.js"></script> 4 <script src="../../http/tests/inspector/console-test.js"></script>
5 <script> 5 <script>
6 6
7 // Global Values 7 // Global Values
8 var globals = []; 8 var globals = [];
9 9
10 function log(current) 10 function log(current)
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 var valuedAttribute = document.createAttribute("attr"); 45 var valuedAttribute = document.createAttribute("attr");
46 valuedAttribute.value = "value"; 46 valuedAttribute.value = "value";
47 var existingAttribute = document.getElementById("x").attributes[0]; 47 var existingAttribute = document.getElementById("x").attributes[0];
48 var throwingLengthGetter = {get length() { throw "Length called"; }}; 48 var throwingLengthGetter = {get length() { throw "Length called"; }};
49 var objectWithNonEnumerables = Object.create({ foo: 1 }, { 49 var objectWithNonEnumerables = Object.create({ foo: 1 }, {
50 getFoo: { value: function() { return this.foo; } }, 50 getFoo: { value: function() { return this.foo; } },
51 bar: { get: function() { return this.bar; }, set: function(x) { this.bar = x; } } 51 bar: { get: function() { return this.bar; }, set: function(x) { this.bar = x; } }
52 }); 52 });
53 var negZero = 1 / Number.NEGATIVE_INFINITY; 53 var negZero = 1 / Number.NEGATIVE_INFINITY;
54 54
55 var arrayLikeFunction = function() {};
56 arrayLikeFunction.splice = function() {};
57
55 globals = [ 58 globals = [
56 regex1, regex2, str, str2, error, errorWithMessage, node, func, multilin efunc, num, linkify, 59 regex1, regex2, str, str2, error, errorWithMessage, node, func, multilin efunc, num, linkify,
57 null, undefined, valuelessAttribute, valuedAttribute, existingAttribute, throwingLengthGetter, 60 null, undefined, valuelessAttribute, valuedAttribute, existingAttribute, throwingLengthGetter,
58 NaN, Number.POSITIVE_INFINITY, Number.NEGATIVE_INFINITY, array, {}, [fun ction() {}], bar, svg, 61 NaN, Number.POSITIVE_INFINITY, Number.NEGATIVE_INFINITY, array, {}, [fun ction() {}], bar, svg,
59 objectWithNonEnumerables, negZero, Object.create(null), Object, Object.p rototype 62 objectWithNonEnumerables, negZero, Object.create(null), Object, Object.p rototype, arrayLikeFunction
60 ]; 63 ];
61 64
62 runTest(); 65 runTest();
63 } 66 }
64 67
65 function test() 68 function test()
66 { 69 {
67 InspectorTest.evaluateInPage("globals.length", loopOverGlobals.bind(this, 0) ); 70 InspectorTest.evaluateInPage("globals.length", loopOverGlobals.bind(this, 0) );
68 71
69 function loopOverGlobals(current, total) 72 function loopOverGlobals(current, total)
(...skipping 26 matching lines...) Expand all
96 } 99 }
97 </script> 100 </script>
98 </head> 101 </head>
99 102
100 <body onload="onload()"> 103 <body onload="onload()">
101 <div id="x"></div> 104 <div id="x"></div>
102 <p id="p">Tests that console logging dumps proper messages.</p> 105 <p id="p">Tests that console logging dumps proper messages.</p>
103 </body> 106 </body>
104 <svg id="svg-node"></svg> 107 <svg id="svg-node"></svg>
105 </html> 108 </html>
OLDNEW
« no previous file with comments | « no previous file | LayoutTests/inspector/console/console-format-collections.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698