Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1970573004: [css-grid] Consider invalid using just "span" as grid-line value (Closed)

Created:
4 years, 7 months ago by Manuel Rego
Modified:
4 years, 7 months ago
CC:
chromium-reviews, jfernandez, svillar, blink-reviews-css, Manuel Rego, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Consider invalid using just "span" as grid-line value The spec is pretty clear about this: https://drafts.csswg.org/css-grid/#typedef-grid-row-start-grid-line The possible options when using "span" to reference a grid line are: [ span && [ <integer> || <custom-ident> ] ] Thus, "span" keyword alone produces an invalid declaration. Add test case in grid-item-column-row-get-set.html. Updated other tests that were using "span" alone, with 2 approaches: * In some of them changing "span" by "span 1" making it valid. * In other changing the expected result to "auto", as it's invalid now. BUG=563400 TEST=fast/css-grid-layout/grid-item-column-row-get-set.html Committed: https://crrev.com/550b6b9f75065106d09aed429937a9c7b4b31b87 Cr-Commit-Position: refs/heads/master@{#393202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -24 lines) Patch
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-area-get-set.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html View 4 chunks +8 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set-expected.txt View 3 chunks +24 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-end-after-get-set.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-end-after-get-set-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Manuel Rego
4 years, 7 months ago (2016-05-11 21:21:06 UTC) #2
rwlbuis
PTAL (assuming it shows up all green).
4 years, 7 months ago (2016-05-11 21:42:56 UTC) #3
rwlbuis
On 2016/05/11 21:42:56, rwlbuis wrote: > PTAL (assuming it shows up all green). Arg, I ...
4 years, 7 months ago (2016-05-11 22:25:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970573004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970573004/1
4 years, 7 months ago (2016-05-12 06:42:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 07:52:23 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 07:54:01 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/550b6b9f75065106d09aed429937a9c7b4b31b87
Cr-Commit-Position: refs/heads/master@{#393202}

Powered by Google App Engine
This is Rietveld 408576698