Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html

Issue 1970573004: [css-grid] Consider invalid using just "span" as grid-line value (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-area-get-set.html ('k') | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html> 2 <html>
3 <link href="resources/grid.css" rel="stylesheet"> 3 <link href="resources/grid.css" rel="stylesheet">
4 <style> 4 <style>
5 .grid { 5 .grid {
6 grid-template-rows: 10px 20px; 6 grid-template-rows: 10px 20px;
7 grid-auto-rows: 5px; 7 grid-auto-rows: 5px;
8 grid-template-columns: 30px 40px; 8 grid-template-columns: 30px 40px;
9 grid-auto-columns: 15px; 9 grid-auto-columns: 15px;
10 grid-auto-flow: row; 10 grid-auto-flow: row;
(...skipping 12 matching lines...) Expand all
23 } 23 }
24 24
25 .namedGridLineSpanRow { 25 .namedGridLineSpanRow {
26 grid-row: nonExistentArea / span 5 firstRow; 26 grid-row: nonExistentArea / span 5 firstRow;
27 grid-column: 1; 27 grid-column: 1;
28 background-color: lime; 28 background-color: lime;
29 } 29 }
30 30
31 .namedGridLineSpanColumn { 31 .namedGridLineSpanColumn {
32 grid-row: 1; 32 grid-row: 1;
33 grid-column: nonExistentArea / span; 33 grid-column: nonExistentArea / span 1;
34 background-color: lime; 34 background-color: lime;
35 } 35 }
36 </style> 36 </style>
37 <script src="../../resources/check-layout.js"></script> 37 <script src="../../resources/check-layout.js"></script>
38 <body onload="checkLayout('.grid')"> 38 <body onload="checkLayout('.grid')">
39 39
40 <p>This test checks that unknown named area are are resolved properly considerin g all the implicit grid lines to have the given names.</p> 40 <p>This test checks that unknown named area are are resolved properly considerin g all the implicit grid lines to have the given names.</p>
41 41
42 <div style="position: relative"> 42 <div style="position: relative">
43 <div class="grid"> 43 <div class="grid">
(...skipping 18 matching lines...) Expand all
62 62
63 <div style="position: relative"> 63 <div style="position: relative">
64 <div class="grid"> 64 <div class="grid">
65 <div class="sizedToGridArea firstRowFirstColumn" data-offset-x="0" data- offset-y="0" data-expected-width="30" data-expected-height="10"></div> 65 <div class="sizedToGridArea firstRowFirstColumn" data-offset-x="0" data- offset-y="0" data-expected-width="30" data-expected-height="10"></div>
66 <div class="sizedToGridArea namedGridLineSpanColumn" data-offset-x="85" data-offset-y="0" data-expected-width="15" data-expected-height="10"></div> 66 <div class="sizedToGridArea namedGridLineSpanColumn" data-offset-x="85" data-offset-y="0" data-expected-width="15" data-expected-height="10"></div>
67 </div> 67 </div>
68 </div> 68 </div>
69 69
70 </body> 70 </body>
71 </html> 71 </html>
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-area-get-set.html ('k') | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698