Issue 197037: Use fucomi instruction to compare floats and put results directly into EFLAGS...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 197037: Use fucomi instruction to compare floats and put results directly into EFLAGS... (Closed)

Created:
11 years, 3 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Use fucomi instruction to compare floats and put results directly into EFLAGS.

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -57 lines)			Patch
M	src/ia32/assembler-ia32.h	View	1 chunk	+1 line, -0 lines	1 comment	Download
M	src/ia32/assembler-ia32.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	2 chunks	+3 lines, -11 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	1 chunk	+11 lines, -5 lines	0 comments	Download
M	src/x64/assembler-x64.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	2 chunks	+9 lines, -29 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 chunk	+3 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

William Hesse

Follows suggestions made in bugs http://code.google.com/p/v8/issues/detail?id=376 and http://code.google.com/p/v8/issues/detail?id=433

11 years, 3 months ago (2009-09-07 12:29:39 UTC) #1

William Hesse

Committed as revision http://code.google.com/p/v8/source/detail?r=3100

11 years, 2 months ago (2009-10-21 09:25:42 UTC) #3

Søren Thygesen Gjesse

11 years, 2 months ago (2009-10-21 11:53:23 UTC) #4

http://codereview.chromium.org/197037/diff/1/5
File src/ia32/assembler-ia32.h (right):

http://codereview.chromium.org/197037/diff/1/5#newcode699
Line 699: void fucomip();
I this instruction supported by the disassembler?

Expand Messages | Collapse Messages