src/x64/macro-assembler-x64.cc - Issue 197037: Use fucomi instruction to compare floats and put results directly into EFLAGS...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/macro-assembler-x64.cc

Issue 197037: Use fucomi instruction to compare floats and put results directly into EFLAGS... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/macro-assembler-x64.cc

===================================================================

--- src/x64/macro-assembler-x64.cc (revision 2836)

+++ src/x64/macro-assembler-x64.cc (working copy)

@@ -597,18 +597,9 @@

void MacroAssembler::FCmp() {

- fcompp();

- push(rax);

- fnstsw_ax();

- if (CpuFeatures::IsSupported(CpuFeatures::SAHF)) {

- sahf();

- } else {

- shrl(rax, Immediate(8));

- and_(rax, Immediate(0xFF));

- push(rax);

- popfq();

- }

- pop(rax);

+ fucomip();

+ ffree(0);

+ fincstp();

}

« src/ia32/assembler-ia32.h ('K') | « src/x64/codegen-x64.cc ('k') | no next file » | no next file with comments »