src/ia32/macro-assembler-ia32.cc - Issue 197037: Use fucomi instruction to compare floats and put results directly into EFLAGS...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/macro-assembler-ia32.cc

Issue 197037: Use fucomi instruction to compare floats and put results directly into EFLAGS... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/macro-assembler-ia32.cc

===================================================================

--- src/ia32/macro-assembler-ia32.cc (revision 2836)

+++ src/ia32/macro-assembler-ia32.cc (working copy)

@@ -319,11 +319,17 @@

void MacroAssembler::FCmp() {

- fcompp();

- push(eax);

- fnstsw_ax();

- sahf();

- pop(eax);

+ if (CpuFeatures::IsSupported(CpuFeatures::CMOV)) {

+ fucomip();

+ ffree(0);

+ fincstp();

+ } else {

+ fucompp();

+ push(eax);

+ fnstsw_ax();

+ sahf();

+ pop(eax);

+ }

}

« src/ia32/assembler-ia32.h ('K') | « src/ia32/codegen-ia32.cc ('k') | src/x64/assembler-x64.h » ('j') | no next file with comments »