Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: media/cdm/ppapi/ppapi_cdm_adapter.gni

Issue 1969503002: Address more TOOD(GYP) in GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« extensions/BUILD.gn ('K') | « extensions/shell/BUILD.gn ('k') | media/gpu/BUILD.gn » ('j') | media/media_options.gni » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cdm/ppapi/ppapi_cdm_adapter.gni
diff --git a/media/cdm/ppapi/ppapi_cdm_adapter.gni b/media/cdm/ppapi/ppapi_cdm_adapter.gni
index bf674100683e1ce9da2075fc2e219ef87948d395..028c0ebe730b1eb41815533097c20ee2519e0e06 100644
--- a/media/cdm/ppapi/ppapi_cdm_adapter.gni
+++ b/media/cdm/ppapi/ppapi_cdm_adapter.gni
@@ -7,8 +7,13 @@
# depend on media/media_cdm_adapter.gyp:cdmadapter which would in turn modify
# your target with direct_dependent_settings.
template("ppapi_cdm_adapter") {
- # TODO(GYP) On Mac/Linux this should be a loadable_module.
- shared_library(target_name) {
+ if (is_win) {
+ ppapi_cdm_adapter_target_type = "shared_library"
+ } else {
+ ppapi_cdm_adapter_target_type = "loadable_module"
+ }
+
+ target(ppapi_cdm_adapter_target_type, target_name) {
# Don't filter sources list again.
set_sources_assignment_filter([])
cflags = []
« extensions/BUILD.gn ('K') | « extensions/shell/BUILD.gn ('k') | media/gpu/BUILD.gn » ('j') | media/media_options.gni » ('J')

Powered by Google App Engine
This is Rietveld 408576698