Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: media/cdm/ppapi/ppapi_cdm_adapter.gni

Issue 1969503002: Address more TOOD(GYP) in GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This template defines a CDM adapter target. Just use this as you would a 5 # This template defines a CDM adapter target. Just use this as you would a
6 # normal target and everything should work correctly. If GYP, you would instead 6 # normal target and everything should work correctly. If GYP, you would instead
7 # depend on media/media_cdm_adapter.gyp:cdmadapter which would in turn modify 7 # depend on media/media_cdm_adapter.gyp:cdmadapter which would in turn modify
8 # your target with direct_dependent_settings. 8 # your target with direct_dependent_settings.
9 template("ppapi_cdm_adapter") { 9 template("ppapi_cdm_adapter") {
10 # TODO(GYP) On Mac/Linux this should be a loadable_module. 10 if (is_win) {
11 shared_library(target_name) { 11 ppapi_cdm_adapter_target_type = "shared_library"
12 } else {
13 ppapi_cdm_adapter_target_type = "loadable_module"
14 }
15
16 target(ppapi_cdm_adapter_target_type, target_name) {
12 # Don't filter sources list again. 17 # Don't filter sources list again.
13 set_sources_assignment_filter([]) 18 set_sources_assignment_filter([])
14 cflags = [] 19 cflags = []
15 sources = [] 20 sources = []
16 ldflags = [] 21 ldflags = []
17 libs = [] 22 libs = []
18 forward_variables_from(invoker, "*") 23 forward_variables_from(invoker, "*")
19 24
20 defines += [ "USE_PPAPI_CDM_ADAPTER" ] 25 defines += [ "USE_PPAPI_CDM_ADAPTER" ]
21 deps += [ 26 deps += [
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 60
56 if (is_linux && !is_component_build) { 61 if (is_linux && !is_component_build) {
57 # CDM adapter depends on a CDM even in non-component builds. 62 # CDM adapter depends on a CDM even in non-component builds.
58 configs += [ "//build/config/gcc:rpath_for_built_shared_libraries" ] 63 configs += [ "//build/config/gcc:rpath_for_built_shared_libraries" ]
59 } 64 }
60 65
61 # TODO(jschuh) crbug.com/167187 66 # TODO(jschuh) crbug.com/167187
62 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] 67 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
63 } 68 }
64 } 69 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698