extensions/BUILD.gn - Issue 1969503002: Address more TOOD(GYP) in GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/BUILD.gn

Issue 1969503002: Address more TOOD(GYP) in GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: android Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/BUILD.gn

diff --git a/extensions/BUILD.gn b/extensions/BUILD.gn

index 1a8059e142f82a6b5ce4f17c78ba5a14eab50113..b5e790f07ac0a8537cd845974942560178fe1851 100644

--- a/extensions/BUILD.gn

+++ b/extensions/BUILD.gn

@@ -251,14 +251,6 @@ test("extensions_browsertests") {

"//third_party/mesa:osmesa",

]

- if (is_win) {

- if (target_cpu == "x86") {

- data_deps += [

- # "$root_out_dir/wow_helper.exe" # TODO(GYP)

brettw 2016/05/10 19:51:33 This comes automatically because this target depen

- ]

- }

if (is_mac) {

deps += [ "shell:app_shell" ] # Needed for App Shell.app's Helper.

}

« no previous file with comments | « no previous file | extensions/shell/BUILD.gn » ('j') | media/media_options.gni » ('J')