Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Issue 1969163002: Give the media context small memory limits (same as compositor). (Closed)

Created:
4 years, 7 months ago by danakj
Modified:
4 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, piman+watch_chromium.org, darin-cc_chromium.org, Daniele Castagna, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Give the media context small memory limits (same as compositor). This makes a static gpu::SharedMemoryLimits::ForMailboxContext() method so that RenderThreadImpl and RenderWidget can share the same limits for the media context and the compositor context which both use the context for creating textures and mailboxing them. R=piman@chromium.org BUG=608946 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/0dd9e1efed6a509dad5b7438cbfc8c015b193238 Cr-Commit-Position: refs/heads/master@{#393086}

Patch Set 1 : limitsmedia: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -14 lines) Patch
M content/renderer/render_thread_impl.cc View 5 chunks +15 lines, -10 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +1 line, -4 lines 0 comments Download
M gpu/command_buffer/client/shared_memory_limits.h View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
danakj
4 years, 7 months ago (2016-05-11 20:50:37 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969163002/20001
4 years, 7 months ago (2016-05-11 20:51:20 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-11 21:53:40 UTC) #8
piman
lgtm
4 years, 7 months ago (2016-05-11 22:03:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969163002/20001
4 years, 7 months ago (2016-05-11 22:11:33 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-11 22:15:22 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 22:17:55 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0dd9e1efed6a509dad5b7438cbfc8c015b193238
Cr-Commit-Position: refs/heads/master@{#393086}

Powered by Google App Engine
This is Rietveld 408576698