Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1968963002: Revert of Eagerly remove disposed DOMTimers as observers. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Eagerly remove disposed DOMTimers as observers. (patchset #1 id:1 of https://codereview.chromium.org/1959013002/ ) Reason for revert: Caused issue 610606, reverting to locally investigate how/why. Original issue's description: > Eagerly remove disposed DOMTimers as observers. > > Once the coordinator lets go of a timer, no need to keep it > around as an observer of the ExecutionContext. > > R= > BUG= > > Committed: https://crrev.com/0a297738301705d02f57968334bd6f7c7dc95f4c > Cr-Commit-Position: refs/heads/master@{#392309} TBR=oilpan-reviews@chromium.org,keishi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/b0438b3ba5de4aa326db9197e86ed408edf710a2 Cr-Commit-Position: refs/heads/master@{#392901}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/core/frame/DOMTimer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
sof
Created Revert of Eagerly remove disposed DOMTimers as observers.
4 years, 7 months ago (2016-05-11 11:24:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968963002/1
4 years, 7 months ago (2016-05-11 11:24:34 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-05-11 11:31:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 12:32:14 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 12:33:32 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0438b3ba5de4aa326db9197e86ed408edf710a2
Cr-Commit-Position: refs/heads/master@{#392901}

Powered by Google App Engine
This is Rietveld 408576698