third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp - Issue 1968963002: Revert of Eagerly remove disposed DOMTimers as observers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp

Issue 1968963002: Revert of Eagerly remove disposed DOMTimers as observers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp

diff --git a/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp b/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp

index 1a2b735bfd698615e54b7f4c5043bb8ff03d681f..064b701a006742560a71db1b5edd5c29212f9ec0 100644

--- a/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp

+++ b/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp

@@ -36,8 +36,10 @@

if (timeoutID <= 0)

return;

- if (DOMTimer* removedTimer = m_timers.take(timeoutID))

+ if (DOMTimer* removedTimer = m_timers.get(timeoutID))

removedTimer->disposeTimer();

+ m_timers.remove(timeoutID);

}

DEFINE_TRACE(DOMTimerCoordinator)

« no previous file with comments | « third_party/WebKit/Source/core/frame/DOMTimer.cpp ('k') | no next file » | no next file with comments »