content/browser/frame_host/render_frame_host_impl.h - Issue 1968933002: Fix: tabs slow to response to beforeunload are closed prematurely.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1968933002: Fix: tabs slow to response to beforeunload are closed prematurely. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use whole rfhi::BeforeUnloadAck Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/beforeunload_slow.html ('K') | « chrome/test/data/beforeunload_slow.html ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.h

diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h

index 45d8ca0cffc75a6862df86dcbaef4b24a71fe007..14634ff1aba5d03378febb8649771d74aefa3aca 100644

--- a/content/browser/frame_host/render_frame_host_impl.h

+++ b/content/browser/frame_host/render_frame_host_impl.h

@@ -401,6 +401,9 @@ class CONTENT_EXPORT RenderFrameHostImpl : public RenderFrameHost,

// PlzNavigate: this call happens on all browser-initiated navigations.

void DispatchBeforeUnload(bool for_navigation);

+ // Simulate beforeunloadack on behalf of renderer if it's unrenresponsive.

Charlie Reis 2016/05/19 22:11:56 nit: Space before ack.

+ void ForceBeforeUnloadAck();

Charlie Reis 2016/05/19 22:11:56 nit: s/Force/Simulate/

// Returns true if a call to DispatchBeforeUnload will actually send the

// BeforeUnload IPC. This is the case if the current renderer is live and this

// frame is the main frame.