content/browser/frame_host/render_frame_host_impl.cc - Issue 1968933002: Fix: tabs slow to response to beforeunload are closed prematurely.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1968933002: Fix: tabs slow to response to beforeunload are closed prematurely. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use whole rfhi::BeforeUnloadAck Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_impl.h ('K') | « content/browser/frame_host/render_frame_host_impl.h ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index de78df1b008a679665336147ce250c5ad9bf3a98..0263580ab2bbd960d667caf83478cb5b9d2588ba 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -2124,6 +2124,12 @@ void RenderFrameHostImpl::DispatchBeforeUnload(bool for_navigation) {

}

+void RenderFrameHostImpl::ForceBeforeUnloadAck() {

+ DCHECK(is_waiting_for_beforeunload_ack_);

+ base::TimeTicks approx_renderer_start_time = send_before_unload_start_time_;

+ OnBeforeUnloadACK(true, approx_renderer_start_time, base::TimeTicks::Now());

bool RenderFrameHostImpl::ShouldDispatchBeforeUnload() {

// TODO(creis): Support beforeunload on subframes.

return !GetParent() && IsRenderFrameLive();