chrome/test/data/beforeunload_slow.html - Issue 1968933002: Fix: tabs slow to response to beforeunload are closed prematurely.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/beforeunload_slow.html

Issue 1968933002: Fix: tabs slow to response to beforeunload are closed prematurely. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use whole rfhi::BeforeUnloadAck Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/lifetime/browser_close_manager_browsertest.cc ('K') | « chrome/browser/lifetime/browser_close_manager_browsertest.cc ('k') | content/browser/frame_host/render_frame_host_impl.h » ('j') | content/browser/frame_host/render_frame_host_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/beforeunload_slow.html

diff --git a/chrome/test/data/beforeunload_hang.html b/chrome/test/data/beforeunload_slow.html

similarity index 51%

copy from chrome/test/data/beforeunload_hang.html

copy to chrome/test/data/beforeunload_slow.html

index a952084def394ee463290501ad7943168b028349..4be478fddbedbb673cd06cd11154ee409a8c4b88 100644

--- a/chrome/test/data/beforeunload_hang.html

+++ b/chrome/test/data/beforeunload_slow.html

@@ -2,7 +2,12 @@

<head>

<title>Loading...</title>

- window.onbeforeunload = function(e) { while(true); };

+ window.onbeforeunload = function(e) {

+ var ms = 1500;

Charlie Reis 2016/05/19 22:11:56 Please put a comment saying this is expected to be

+ ms += new Date().getTime();

Charlie Reis 2016/05/19 22:11:56 nit: var finishTime = new Date().getTime() + delay

+ while (new Date() < ms) {}

+ return null;

+ };

</script>

</head>

<body>