chrome/test/data/beforeunload_slow.html - Issue 1968933002: Fix: tabs slow to response to beforeunload are closed prematurely.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/beforeunload_slow.html

Issue 1968933002: Fix: tabs slow to response to beforeunload are closed prematurely. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use whole rfhi::BeforeUnloadAck Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/lifetime/browser_close_manager_browsertest.cc ('K') | « chrome/browser/lifetime/browser_close_manager_browsertest.cc ('k') | content/browser/frame_host/render_frame_host_impl.h » ('j') | content/browser/frame_host/render_frame_host_impl.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <title>Loading...</title>	3 <title>Loading...</title>

4 <script>	4 <script>

5 window.onbeforeunload = function(e) { while(true); };	5 window.onbeforeunload = function(e) {

	6 var ms = 1500;
	Charlie Reis 2016/05/19 22:11:56 Please put a comment saying this is expected to be Please put a comment saying this is expected to be longer than RenderViewHostImpl::kUnloadTimeoutMS. nit: s/ms/delay/
	7 ms += new Date().getTime();
	Charlie Reis 2016/05/19 22:11:56 nit: var finishTime = new Date().getTime() + delay nit: var finishTime = new Date().getTime() + delay;
	8 while (new Date() < ms) {}

	9 return null;

	10 };

6 </script>	11 </script>

7 </head>	12 </head>

8 <body>	13 <body>

9 <p>Navigate to another page to trigger beforeunload handler.</p>	14 <p>Navigate to another page to trigger beforeunload handler.</p>

10 </body>	15 </body>

11 </html>	16 </html>

OLD	NEW