Issue 1968783002: Speed up String.fromCharCodes a bit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1968783002: Speed up String.fromCharCodes a bit (Closed)

Created:
4 years, 7 months ago by sra1

Modified:
4 years, 7 months ago

Reviewers:
Leaf

CC:
dev-compiler+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dev_compiler@master

Target Ref:
refs/heads/master

Visibility:
Public.

Speed up String.fromCharCodes a bit About 4x speedup of convert/ascii_test.dart by removing dsend in inner loop. R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/98cbe45bbc65ff54b4e024ecf7fd255b91a9d68f

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -21 lines)			Patch
M	lib/runtime/dart_sdk.js	View	7 chunks	+16 lines, -16 lines	0 comments	Download
M	tool/input_sdk/patch/core_patch.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tool/input_sdk/private/js_helper.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tool/sdk_expected_errors.txt	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

sra1

I use the comment form of types to avoid extra checks in dart2js --checked.

4 years, 7 months ago (2016-05-10 23:19:35 UTC) #2

sra1

4 years, 7 months ago (2016-05-11 00:30:30 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
98cbe45bbc65ff54b4e024ecf7fd255b91a9d68f (presubmit successful).