tool/input_sdk/patch/core_patch.dart - Issue 1968783002: Speed up String.fromCharCodes a bit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tool/input_sdk/patch/core_patch.dart

Issue 1968783002: Speed up String.fromCharCodes a bit (Closed) Base URL: https://github.com/dart-lang/dev_compiler@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tool/input_sdk/patch/core_patch.dart

diff --git a/tool/input_sdk/patch/core_patch.dart b/tool/input_sdk/patch/core_patch.dart

index 55b7edb98daaf982330e9c566cc8c61a3a61806b..ede6eca2a61ebd6eaade1568a12db979ea0aa13f 100644

--- a/tool/input_sdk/patch/core_patch.dart

+++ b/tool/input_sdk/patch/core_patch.dart

@@ -365,7 +365,8 @@ class String {

'String.fromEnvironment can only be used as a const constructor');

}

- static String _stringFromJSArray(List list, int start, int endOrNull) {

+ static String _stringFromJSArray(

+ /*=JSArray<int>*/ list, int start, int endOrNull) {

int len = list.length;

int end = RangeError.checkValidRange(start, endOrNull, len);

if (start > 0 || end < len) {

« no previous file with comments | « lib/runtime/dart_sdk.js ('k') | tool/input_sdk/private/js_helper.dart » ('j') | no next file with comments »