tool/input_sdk/private/js_helper.dart - Issue 1968783002: Speed up String.fromCharCodes a bit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tool/input_sdk/private/js_helper.dart

Issue 1968783002: Speed up String.fromCharCodes a bit (Closed) Base URL: https://github.com/dart-lang/dev_compiler@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tool/input_sdk/private/js_helper.dart

diff --git a/tool/input_sdk/private/js_helper.dart b/tool/input_sdk/private/js_helper.dart

index 00bc4b5d1be31d0aa022a1a8cd94eb33d3c26c71..bf8a87851cb0efb0324e1b0ee26ec29fbc61bfb4 100644

--- a/tool/input_sdk/private/js_helper.dart

+++ b/tool/input_sdk/private/js_helper.dart

@@ -256,7 +256,7 @@ class Primitives {

return result;

}

- static String stringFromCodePoints(codePoints) {

+ static String stringFromCodePoints(/*=JSArray<int>*/ codePoints) {

List<int> a = <int>[];

for (var i in codePoints) {

if (i is !int) throw argumentErrorValue(i);

@@ -272,7 +272,7 @@ class Primitives {

return _fromCharCodeApply(a);

}

- static String stringFromCharCodes(charCodes) {

+ static String stringFromCharCodes(/*=JSArray<int>*/ charCodes) {

for (var i in charCodes) {

if (i is !int) throw argumentErrorValue(i);

if (i < 0) throw argumentErrorValue(i);

« no previous file with comments | « tool/input_sdk/patch/core_patch.dart ('k') | tool/sdk_expected_errors.txt » ('j') | no next file with comments »