[cleanup] Split ForOf and ForIn AST nodes apart as they share little

[cleanup] Split ForOf and ForIn AST nodes apart as they share little

Also make all AstVisitors consistently visit all the relevant parts
of ForOfStatement. PrettyPrinter no longer fares well, but given
how much desugaring happens to ForOf in the parser, any pretty-printed
view of it isn't going to be human readable. AstPrinter, on the other
hand, now gives a realistic view of what's been generated for for-of.

Committed: https://crrev.com/4a7b9b973b3f39b89c594581932952c64da5ed8b
Cr-Commit-Position: refs/heads/master@{#36215}

[adamk, 2016-05-11 00:48:01]

Description was changed from

==========
Simplify


Add TODO


No longer crashes


Merge remote-tracking branch 'origin' into for-of-cleanup


Remove


Merge remote-tracking branch 'origin' into for-of-cleanup


Merge remote-tracking branch 'origin' into for-of-cleanup


Totally crazy prettyprinting


Builds in release mode


Formatted


Fix all the visitors


Add stuff


Hack for now, working on better fix


Wheee now works


Keep each in there


Demonstration patch for for-of bug

patch from issue 1742023002 at patchset 1 (http://crrev.com/1742023002#ps1)

BUG=
==========

to

==========
[cleanup] Split ForOf and ForIn AST nodes apart as they share little

Also make all AstVisitors consistently visit all the relevant parts
of ForOfStatement. PrettyPrinter no longer fares well, but given
how much desugaring happens to ForOf in the parser, any pretty-printed
view of it isn't going to be human readable. AstPrinter, on the other
hand, now gives a realistic view of what's been generated for for-of.
==========

[adamk, 2016-05-11 00:48:27]

adamk@chromium.org changed reviewers:
+ bmeurer@chromium.org

[adamk, 2016-05-11 22:54:46]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-11 22:54:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1968753004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1968753004/1

[commit-bot: I haz the power, 2016-05-11 23:28:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 23:28:04]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2016-05-12 04:14:27]

Nice. LGTM.

[adamk, 2016-05-12 16:23:38]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2016-05-12 16:23:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1968753004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1968753004/1

[commit-bot: I haz the power, 2016-05-12 16:25:07]

Description was changed from

==========
[cleanup] Split ForOf and ForIn AST nodes apart as they share little

Also make all AstVisitors consistently visit all the relevant parts
of ForOfStatement. PrettyPrinter no longer fares well, but given
how much desugaring happens to ForOf in the parser, any pretty-printed
view of it isn't going to be human readable. AstPrinter, on the other
hand, now gives a realistic view of what's been generated for for-of.
==========

to

==========
[cleanup] Split ForOf and ForIn AST nodes apart as they share little

Also make all AstVisitors consistently visit all the relevant parts
of ForOfStatement. PrettyPrinter no longer fares well, but given
how much desugaring happens to ForOf in the parser, any pretty-printed
view of it isn't going to be human readable. AstPrinter, on the other
hand, now gives a realistic view of what's been generated for for-of.
==========

[commit-bot: I haz the power, 2016-05-12 16:25:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-12 16:27:24]

Description was changed from

==========
[cleanup] Split ForOf and ForIn AST nodes apart as they share little

Also make all AstVisitors consistently visit all the relevant parts
of ForOfStatement. PrettyPrinter no longer fares well, but given
how much desugaring happens to ForOf in the parser, any pretty-printed
view of it isn't going to be human readable. AstPrinter, on the other
hand, now gives a realistic view of what's been generated for for-of.
==========

to

==========
[cleanup] Split ForOf and ForIn AST nodes apart as they share little

Also make all AstVisitors consistently visit all the relevant parts
of ForOfStatement. PrettyPrinter no longer fares well, but given
how much desugaring happens to ForOf in the parser, any pretty-printed
view of it isn't going to be human readable. AstPrinter, on the other
hand, now gives a realistic view of what's been generated for for-of.

Committed: https://crrev.com/4a7b9b973b3f39b89c594581932952c64da5ed8b
Cr-Commit-Position: refs/heads/master@{#36215}
==========

[commit-bot: I haz the power, 2016-05-12 16:27:25]

Patchset 1 (id:??) landed as
https://crrev.com/4a7b9b973b3f39b89c594581932952c64da5ed8b
Cr-Commit-Position: refs/heads/master@{#36215}