Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: src/compiler/ast-loop-assignment-analyzer.cc

Issue 1968753004: [cleanup] Split ForOf and ForIn AST nodes apart as they share little (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ast/prettyprinter.cc ('k') | src/crankshaft/typing.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/ast-loop-assignment-analyzer.h" 5 #include "src/compiler/ast-loop-assignment-analyzer.h"
6 #include "src/compiler.h" 6 #include "src/compiler.h"
7 #include "src/parsing/parser.h" 7 #include "src/parsing/parser.h"
8 8
9 namespace v8 { 9 namespace v8 {
10 namespace internal { 10 namespace internal {
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 Visit(loop->each()); 258 Visit(loop->each());
259 Visit(loop->subject()); 259 Visit(loop->subject());
260 Visit(loop->body()); 260 Visit(loop->body());
261 Exit(loop); 261 Exit(loop);
262 } 262 }
263 263
264 264
265 void ALAA::VisitForOfStatement(ForOfStatement* loop) { 265 void ALAA::VisitForOfStatement(ForOfStatement* loop) {
266 Visit(loop->assign_iterator()); 266 Visit(loop->assign_iterator());
267 Enter(loop); 267 Enter(loop);
268 Visit(loop->next_result());
269 Visit(loop->result_done());
268 Visit(loop->assign_each()); 270 Visit(loop->assign_each());
269 Visit(loop->subject());
270 Visit(loop->body()); 271 Visit(loop->body());
271 Exit(loop); 272 Exit(loop);
272 } 273 }
273 274
274 275
275 void ALAA::VisitAssignment(Assignment* stmt) { 276 void ALAA::VisitAssignment(Assignment* stmt) {
276 Expression* l = stmt->target(); 277 Expression* l = stmt->target();
277 Visit(l); 278 Visit(l);
278 Visit(stmt->value()); 279 Visit(stmt->value());
279 if (l->IsVariableProxy()) AnalyzeAssignment(l->AsVariableProxy()->var()); 280 if (l->IsVariableProxy()) AnalyzeAssignment(l->AsVariableProxy()->var());
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 int count = 0; 313 int count = 0;
313 int var_index = AstLoopAssignmentAnalyzer::GetVariableIndex(scope, var); 314 int var_index = AstLoopAssignmentAnalyzer::GetVariableIndex(scope, var);
314 for (size_t i = 0; i < list_.size(); i++) { 315 for (size_t i = 0; i < list_.size(); i++) {
315 if (list_[i].second->Contains(var_index)) count++; 316 if (list_[i].second->Contains(var_index)) count++;
316 } 317 }
317 return count; 318 return count;
318 } 319 }
319 } // namespace compiler 320 } // namespace compiler
320 } // namespace internal 321 } // namespace internal
321 } // namespace v8 322 } // namespace v8
OLDNEW
« no previous file with comments | « src/ast/prettyprinter.cc ('k') | src/crankshaft/typing.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698