src/ast/ast-expression-visitor.cc - Issue 1968753004: [cleanup] Split ForOf and ForIn AST nodes apart as they share little

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast/ast-expression-visitor.cc

Issue 1968753004: [cleanup] Split ForOf and ForIn AST nodes apart as they share little (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ast/ast-expression-visitor.cc

diff --git a/src/ast/ast-expression-visitor.cc b/src/ast/ast-expression-visitor.cc

index 6dd9aeffdae66a11fd29de391424f035bcfa9708..91d4afb18e6379b29dcb1beee8ca78daa86bb1e2 100644

--- a/src/ast/ast-expression-visitor.cc

+++ b/src/ast/ast-expression-visitor.cc

@@ -170,7 +170,6 @@ void AstExpressionVisitor::VisitForInStatement(ForInStatement* stmt) {

void AstExpressionVisitor::VisitForOfStatement(ForOfStatement* stmt) {

- RECURSE(Visit(stmt->iterable()));

RECURSE(Visit(stmt->assign_iterator()));

RECURSE(Visit(stmt->next_result()));

RECURSE(Visit(stmt->result_done()));

« no previous file with comments | « src/ast/ast-expression-rewriter.cc ('k') | src/ast/prettyprinter.cc » ('j') | no next file with comments »