Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: base/command_line.cc

Issue 196793010: Move IsStringASCII/UTF8 to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/i18n/streaming_utf8_validator_perftest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/command_line.cc
diff --git a/base/command_line.cc b/base/command_line.cc
index be6b4f2b1f4a0419ecd1c635109e4814cf220639..31426cba50a0d061e5b98d2bcaafe8eeb125b51b 100644
--- a/base/command_line.cc
+++ b/base/command_line.cc
@@ -304,7 +304,7 @@ bool CommandLine::HasSwitch(const std::string& switch_string) const {
std::string CommandLine::GetSwitchValueASCII(
const std::string& switch_string) const {
StringType value = GetSwitchValueNative(switch_string);
- if (!IsStringASCII(value)) {
+ if (!base::IsStringASCII(value)) {
DLOG(WARNING) << "Value of switch (" << switch_string << ") must be ASCII.";
return std::string();
}
@@ -386,7 +386,7 @@ CommandLine::StringVector CommandLine::GetArgs() const {
void CommandLine::AppendArg(const std::string& value) {
#if defined(OS_WIN)
- DCHECK(IsStringUTF8(value));
+ DCHECK(base::IsStringUTF8(value));
AppendArgNative(base::UTF8ToWide(value));
#elif defined(OS_POSIX)
AppendArgNative(value);
« no previous file with comments | « no previous file | base/i18n/streaming_utf8_validator_perftest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698