Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1967823002: Only LayoutInline needs to implement addChildIgnoringContinuation(). (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
eae, szager1, wkorman
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only LayoutInline needs to implement addChildIgnoringContinuation(). LayoutTable had to do it because LayoutBlock did it. But LayoutBlock really doesn't have to do it anymore. This was probably some relic from the old multicol implementation, which used *block* continuations to implement column spanners. We no longer need or support block continuations. Committed: https://crrev.com/679cad2b5547aa02b33f8876c228b5e640fd6228 Cr-Commit-Position: refs/heads/master@{#392856}

Patch Set 1 #

Patch Set 2 : rebase master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -19 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 2 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-10 22:11:27 UTC) #2
wkorman
lgtm
4 years, 7 months ago (2016-05-10 22:18:20 UTC) #3
eae
LGTM
4 years, 7 months ago (2016-05-10 22:27:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967823002/20001
4 years, 7 months ago (2016-05-11 04:55:55 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-11 04:59:27 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 05:00:57 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/679cad2b5547aa02b33f8876c228b5e640fd6228
Cr-Commit-Position: refs/heads/master@{#392856}

Powered by Google App Engine
This is Rietveld 408576698