Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTable.cpp

Issue 1967823002: Only LayoutInline needs to implement addChildIgnoringContinuation(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase master Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTable.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutTable.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTable.cpp b/third_party/WebKit/Source/core/layout/LayoutTable.cpp
index dd5530407f85345862ddb6040de5cd5eb7935732..f2d07afdd4a1d0b205fc0dc6dec3732be3007905 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTable.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTable.cpp
@@ -206,16 +206,6 @@ void LayoutTable::addChild(LayoutObject* child, LayoutObject* beforeChild)
section->addChild(child);
}
-void LayoutTable::addChildIgnoringContinuation(LayoutObject* newChild, LayoutObject* beforeChild)
-{
- // We need to bypass the LayoutBlock implementation and instead do a normal addChild() (or we
- // won't get there at all), so that any missing anonymous table part layoutObjects are
- // inserted. Otherwise we might end up with an insane layout tree with inlines or blocks as
- // direct children of a table, which will break assumptions made all over the code, which may
- // lead to crashers and security issues.
- addChild(newChild, beforeChild);
-}
-
void LayoutTable::addCaption(const LayoutTableCaption* caption)
{
ASSERT(m_captions.find(caption) == kNotFound);
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTable.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698