Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBlock.h

Issue 1967823002: Only LayoutInline needs to implement addChildIgnoringContinuation(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase master Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 376 matching lines...) Expand 10 before | Expand all | Expand 10 after
387 bool isLayoutBlock() const final { return true; } 387 bool isLayoutBlock() const final { return true; }
388 388
389 void makeChildrenNonInline(LayoutObject* insertionPoint = nullptr); 389 void makeChildrenNonInline(LayoutObject* insertionPoint = nullptr);
390 390
391 virtual void removeLeftoverAnonymousBlock(LayoutBlock* child); 391 virtual void removeLeftoverAnonymousBlock(LayoutBlock* child);
392 392
393 void makeChildrenInlineIfPossible(); 393 void makeChildrenInlineIfPossible();
394 394
395 void dirtyLinesFromChangedChild(LayoutObject* child) final { m_lineBoxes.dir tyLinesFromChangedChild(LineLayoutItem(this), LineLayoutItem(child)); } 395 void dirtyLinesFromChangedChild(LayoutObject* child) final { m_lineBoxes.dir tyLinesFromChangedChild(LineLayoutItem(this), LineLayoutItem(child)); }
396 396
397 void addChildIgnoringContinuation(LayoutObject* newChild, LayoutObject* befo reChild) override;
398
399 TrackedLayoutBoxListHashSet* positionedObjectsInternal() const; 397 TrackedLayoutBoxListHashSet* positionedObjectsInternal() const;
400 TrackedLayoutBoxListHashSet* percentHeightDescendantsInternal() const; 398 TrackedLayoutBoxListHashSet* percentHeightDescendantsInternal() const;
401 399
402 Node* nodeForHitTest() const final; 400 Node* nodeForHitTest() const final;
403 401
404 // Returns true if the positioned movement-only layout succeeded. 402 // Returns true if the positioned movement-only layout succeeded.
405 bool tryLayoutDoingPositionedMovementOnly(); 403 bool tryLayoutDoingPositionedMovementOnly();
406 404
407 bool avoidsFloats() const override { return true; } 405 bool avoidsFloats() const override { return true; }
408 406
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
490 // FIXME: This is temporary as we move code that accesses block flow 488 // FIXME: This is temporary as we move code that accesses block flow
491 // member variables out of LayoutBlock and into LayoutBlockFlow. 489 // member variables out of LayoutBlock and into LayoutBlockFlow.
492 friend class LayoutBlockFlow; 490 friend class LayoutBlockFlow;
493 }; 491 };
494 492
495 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlock, isLayoutBlock()); 493 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlock, isLayoutBlock());
496 494
497 } // namespace blink 495 } // namespace blink
498 496
499 #endif // LayoutBlock_h 497 #endif // LayoutBlock_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698