tracing/tracing/base/base.html - Issue 1967613003: Migrate child element manipulation, innerHTML, classList, attributes,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/base/base.html

Issue 1967613003: Migrate child element manipulation, innerHTML, classList, attributes, (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tracing/tracing/base/base.html

diff --git a/tracing/tracing/base/base.html b/tracing/tracing/base/base.html

index 53239739c8c6c0b0ade3d9f9dfc8608b9ef63f66..516276f11a34b12b8030584362d9010be93b1b0a 100644

--- a/tracing/tracing/base/base.html

+++ b/tracing/tracing/base/base.html

@@ -119,11 +119,13 @@ this.tr = (function() {

showPanicElementIfNeeded();

var panicMessageEl = document.createElement('div');

- panicMessageEl.innerHTML =

+ Polymer.dom(panicMessageEl).innerHTML =

'<h2 id="message"></h2>' +

'<pre id="details"></pre>';

- panicMessageEl.querySelector('#message').textContent = panicTitle;

- panicMessageEl.querySelector('#details').textContent = panicDetails;

+ Polymer.dom(panicMessageEl).querySelector('#message').

charliea (OOO until 10-5) 2016/05/10 18:53:17 nit (here and elswhere): we always break before th

+ textContent = panicTitle;

+ Polymer.dom(panicMessageEl).querySelector('#details').

+ textContent = panicDetails;

Polymer.dom(panicElement).appendChild(panicMessageEl);

rawPanicMessages.push({

« no previous file with comments | « no previous file | tracing/tracing/base/unittest/html_test_results.html » ('j') | tracing/tracing/ui/timeline_track_view.html » ('J')