Chromium Code Reviews Chromium Code Reviews
Issue 1967613003:
Migrate child element manipulation, innerHTML, classList, attributes, (Closed)
Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <!-- | 2 <!-- |
| 3 Copyright (c) 2014 The Chromium Authors. All rights reserved. | 3 Copyright (c) 2014 The Chromium Authors. All rights reserved. |
| 4 Use of this source code is governed by a BSD-style license that can be | 4 Use of this source code is governed by a BSD-style license that can be |
| 5 found in the LICENSE file. | 5 found in the LICENSE file. |
| 6 --> | 6 --> |
| 7 | 7 |
| 8 <script> | 8 <script> |
| 9 'use strict'; | 9 'use strict'; |
| 10 | 10 |
| (...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 112 if (panicDetails instanceof Error) | 112 if (panicDetails instanceof Error) |
| 113 throw panicDetails; | 113 throw panicDetails; |
| 114 throw new Error('Panic: ' + panicTitle + ':\n' + panicDetails); | 114 throw new Error('Panic: ' + panicTitle + ':\n' + panicDetails); |
| 115 } | 115 } |
| 116 | 116 |
| 117 if (panicDetails instanceof Error) | 117 if (panicDetails instanceof Error) |
| 118 panicDetails = panicDetails.stack; | 118 panicDetails = panicDetails.stack; |
| 119 | 119 |
| 120 showPanicElementIfNeeded(); | 120 showPanicElementIfNeeded(); |
| 121 var panicMessageEl = document.createElement('div'); | 121 var panicMessageEl = document.createElement('div'); |
| 122 panicMessageEl.innerHTML = | 122 Polymer.dom(panicMessageEl).innerHTML = |
| 123 '<h2 id="message"></h2>' + | 123 '<h2 id="message"></h2>' + |
| 124 '<pre id="details"></pre>'; | 124 '<pre id="details"></pre>'; |
| 125 panicMessageEl.querySelector('#message').textContent = panicTitle; | 125 Polymer.dom(panicMessageEl).querySelector('#message'). |
|
charliea (OOO until 10-5)
2016/05/10 18:53:17
nit (here and elswhere): we always break before th
| |
| 126 panicMessageEl.querySelector('#details').textContent = panicDetails; | 126 textContent = panicTitle; |
| 127 Polymer.dom(panicMessageEl).querySelector('#details'). | |
| 128 textContent = panicDetails; | |
| 127 Polymer.dom(panicElement).appendChild(panicMessageEl); | 129 Polymer.dom(panicElement).appendChild(panicMessageEl); |
| 128 | 130 |
| 129 rawPanicMessages.push({ | 131 rawPanicMessages.push({ |
| 130 title: panicTitle, | 132 title: panicTitle, |
| 131 details: panicDetails | 133 details: panicDetails |
| 132 }); | 134 }); |
| 133 } | 135 } |
| 134 | 136 |
| 135 function hasPanic() { | 137 function hasPanic() { |
| 136 return rawPanicMessages.length !== 0; | 138 return rawPanicMessages.length !== 0; |
| (...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 185 isDefined: isDefined, | 187 isDefined: isDefined, |
| 186 | 188 |
| 187 showPanic: showPanic, | 189 showPanic: showPanic, |
| 188 hasPanic: hasPanic, | 190 hasPanic: hasPanic, |
| 189 getPanicText: getPanicText | 191 getPanicText: getPanicText |
| 190 }; | 192 }; |
| 191 })(); | 193 })(); |
| 192 | 194 |
| 193 tr.initialize(); | 195 tr.initialize(); |
| 194 </script> | 196 </script> |
| OLD | NEW |
