tracing/tracing/ui/timeline_track_view.html - Issue 1967613003: Migrate child element manipulation, innerHTML, classList, attributes,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/timeline_track_view.html

Issue 1967613003: Migrate child element manipulation, innerHTML, classList, attributes, (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tracing/tracing/ui/timeline_track_view.html

diff --git a/tracing/tracing/ui/timeline_track_view.html b/tracing/tracing/ui/timeline_track_view.html

index 8a7bd030f59a054b2d55db78e68b8b81b977d845..b796d2d69c59ae4fc0cd9db66afbef5a650b8718 100644

--- a/tracing/tracing/ui/timeline_track_view.html

+++ b/tracing/tracing/ui/timeline_track_view.html

@@ -109,6 +109,8 @@ Polymer({

this.viewport_.modelTrackContainer = this.modelTrackContainer_;

this.modelTrack_ = new tr.ui.tracks.ModelTrack(this.viewport_);

+ if (!this.modelTrack_)

aiolos (Not reviewing) 2016/05/10 17:52:46 whoops, I forgot to strip this. I'll remove.

+ console.log('modelTrack not created');

Polymer.dom(this.modelTrackContainer_).appendChild(this.modelTrack_);

this.timingTool_ = new tr.ui.b.TimingTool(this.viewport_, this);

« tracing/tracing/base/base.html ('K') | « tracing/tracing/ui/side_panel/side_panel_container.html ('k') | tracing/tracing/ui/timeline_view.html » ('j') | no next file with comments »