Fix assertion failure when exception is thrown during keyframe iteration

Fix assertion failure when exception is thrown during keyframe iteration

The code that exhausts iterables passed into element.animate() did not
take Javascript exceptions into account when asserting on exception
state.

BUG=610482
Committed: https://crrev.com/965a648d5477aeb0bcb10b08d06d68ad3934d426
Cr-Commit-Position: refs/heads/master@{#392851}

[alancutter (OOO until 2018), 2016-05-10 07:34:00]

alancutter@chromium.org changed reviewers:
+ suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-05-10 07:50:35]

https://codereview.chromium.org/1967463002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/animations/keyframe-iteration-exception-crash.html
(right):

https://codereview.chromium.org/1967463002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/keyframe-iteration-exception-crash.html:13:
} catch (error) {}
Should there be something in the catch clause to indicate whether or not we
expect to get there?

https://codereview.chromium.org/1967463002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/keyframe-iteration-exception-crash.html:14:
}, 'Do not crash when exceptions are throw during keyframe iteration.');
typo: throw -> thrown

[alancutter (OOO until 2018), 2016-05-11 00:26:21]

https://codereview.chromium.org/1967463002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/animations/keyframe-iteration-exception-crash.html
(right):

https://codereview.chromium.org/1967463002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/keyframe-iteration-exception-crash.html:13:
} catch (error) {}
On 2016/05/10 at 07:50:34, suzyh wrote:
> Should there be something in the catch clause to indicate whether or not we
expect to get there?

Using assert_throws().

https://codereview.chromium.org/1967463002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/keyframe-iteration-exception-crash.html:14:
}, 'Do not crash when exceptions are throw during keyframe iteration.');
On 2016/05/10 at 07:50:34, suzyh wrote:
> typo: throw -> thrown

Done.

[suzyh_UTC10 (ex-contributor), 2016-05-11 00:38:26]

lgtm

[alancutter (OOO until 2018), 2016-05-11 00:43:55]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2016-05-11 00:44:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1967463002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1967463002/20001

[commit-bot: I haz the power, 2016-05-11 04:30:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-11 04:31:22]

Description was changed from

==========
Fix assertion failure when exception is thrown during keyframe iteration

The code that exhausts iterables passed into element.animate() did not
take Javascript exceptions into account when asserting on exception
state.

BUG=610482
==========

to

==========
Fix assertion failure when exception is thrown during keyframe iteration

The code that exhausts iterables passed into element.animate() did not
take Javascript exceptions into account when asserting on exception
state.

BUG=610482

Committed: https://crrev.com/965a648d5477aeb0bcb10b08d06d68ad3934d426
Cr-Commit-Position: refs/heads/master@{#392851}
==========

[commit-bot: I haz the power, 2016-05-11 04:31:24]

Patchset 2 (id:??) landed as
https://crrev.com/965a648d5477aeb0bcb10b08d06d68ad3934d426
Cr-Commit-Position: refs/heads/master@{#392851}