Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1967463002: Fix assertion failure when exception is thrown during keyframe iteration (Closed)

Created:
4 years, 7 months ago by alancutter (OOO until 2018)
Modified:
4 years, 7 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix assertion failure when exception is thrown during keyframe iteration The code that exhausts iterables passed into element.animate() did not take Javascript exceptions into account when asserting on exception state. BUG=610482 Committed: https://crrev.com/965a648d5477aeb0bcb10b08d06d68ad3934d426 Cr-Commit-Position: refs/heads/master@{#392851}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/animations/keyframe-iteration-exception-crash.html View 1 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/EffectInput.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
alancutter (OOO until 2018)
4 years, 7 months ago (2016-05-10 07:34:00 UTC) #2
suzyh_UTC10 (ex-contributor)
https://codereview.chromium.org/1967463002/diff/1/third_party/WebKit/LayoutTests/animations/keyframe-iteration-exception-crash.html File third_party/WebKit/LayoutTests/animations/keyframe-iteration-exception-crash.html (right): https://codereview.chromium.org/1967463002/diff/1/third_party/WebKit/LayoutTests/animations/keyframe-iteration-exception-crash.html#newcode13 third_party/WebKit/LayoutTests/animations/keyframe-iteration-exception-crash.html:13: } catch (error) {} Should there be something in ...
4 years, 7 months ago (2016-05-10 07:50:35 UTC) #3
alancutter (OOO until 2018)
https://codereview.chromium.org/1967463002/diff/1/third_party/WebKit/LayoutTests/animations/keyframe-iteration-exception-crash.html File third_party/WebKit/LayoutTests/animations/keyframe-iteration-exception-crash.html (right): https://codereview.chromium.org/1967463002/diff/1/third_party/WebKit/LayoutTests/animations/keyframe-iteration-exception-crash.html#newcode13 third_party/WebKit/LayoutTests/animations/keyframe-iteration-exception-crash.html:13: } catch (error) {} On 2016/05/10 at 07:50:34, suzyh ...
4 years, 7 months ago (2016-05-11 00:26:21 UTC) #4
suzyh_UTC10 (ex-contributor)
lgtm
4 years, 7 months ago (2016-05-11 00:38:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967463002/20001
4 years, 7 months ago (2016-05-11 00:44:16 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-11 04:30:10 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 04:31:24 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/965a648d5477aeb0bcb10b08d06d68ad3934d426
Cr-Commit-Position: refs/heads/master@{#392851}

Powered by Google App Engine
This is Rietveld 408576698