Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: third_party/WebKit/Source/core/animation/EffectInput.cpp

Issue 1967463002: Fix assertion failure when exception is thrown during keyframe iteration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review changes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/animations/keyframe-iteration-exception-crash.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/animation/EffectInput.cpp
diff --git a/third_party/WebKit/Source/core/animation/EffectInput.cpp b/third_party/WebKit/Source/core/animation/EffectInput.cpp
index d5226762ec115b23b84e980c7cddc96153edd4c8..fe5944dc6b59fdaea1c53b484870a0dab38d5012 100644
--- a/third_party/WebKit/Source/core/animation/EffectInput.cpp
+++ b/third_party/WebKit/Source/core/animation/EffectInput.cpp
@@ -139,7 +139,7 @@ bool exhaustDictionaryIterator(DictionaryIterator& iterator, ExecutionContext* e
}
result.append(dictionary);
}
- return true;
+ return !exceptionState.hadException();
}
} // namespace
« no previous file with comments | « third_party/WebKit/LayoutTests/animations/keyframe-iteration-exception-crash.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698