third_party/WebKit/LayoutTests/animations/keyframe-iteration-exception-crash.html - Issue 1967463002: Fix assertion failure when exception is thrown during keyframe iteration

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/animations/keyframe-iteration-exception-crash.html

Issue 1967463002: Fix assertion failure when exception is thrown during keyframe iteration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <div id="target"></div>

	5 <script>

	6 test(() => {

	7 try {

	8 target.animate({

	9 [Symbol.iterator]() {

	10 return { next() { throw 'error'; } };

	11 }

	12 });

	13 } catch (error) {}
	suzyh_UTC10 (ex-contributor) 2016/05/10 07:50:34 Should there be something in the catch clause to i Should there be something in the catch clause to indicate whether or not we expect to get there? alancutter (OOO until 2018) 2016/05/11 00:26:21 Using assert_throws(). Show quoted text On 2016/05/10 at 07:50:34, suzyh wrote: > Should there be something in the catch clause to indicate whether or not we expect to get there? Using assert_throws().
	14 }, 'Do not crash when exceptions are throw during keyframe iteration.');
	suzyh_UTC10 (ex-contributor) 2016/05/10 07:50:34 typo: throw -> thrown typo: throw -> thrown alancutter (OOO until 2018) 2016/05/11 00:26:21 Done. Show quoted text On 2016/05/10 at 07:50:34, suzyh wrote: > typo: throw -> thrown Done.
	15 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/EffectInput.cpp » ('j') | no next file with comments »