All source types working for linear pipeline.

This has all the different source types in and working. There are many SkDiffs, but they seem to be due to better resolution.

This seems to fix all the bugs involved with make all the images produced by the codec to default to sRGB.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1967283002

Committed: https://skia.googlesource.com/skia/+/670f01f2fc88f02ec9a6f1b47af29daeadc3b301

[herb_g, 2016-05-11 21:55:20]

Description was changed from

==========
All the pixel sources are in and wired up.
BUG=skia:
==========

to

==========
All the pixel sources are in and wired up.
BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[herb_g, 2016-05-12 21:50:00]

All source types working for linear pipeline.

[herb_g, 2016-05-12 21:53:33]

Description was changed from

==========
All the pixel sources are in and wired up.
BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
This has all the different source types in and working. There are many SkDiffs,
but they seem to be due to better resolution.

This seems to fix all the bugs involved with make all the images produced by the
codec to default to sRGB.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[herb_g, 2016-05-12 21:53:33]

herb@google.com changed reviewers:
+ fmalita@chromium.org

[herb_g, 2016-05-12 21:53:46]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 21:53:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1967283002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1967283002/20001

[commit-bot: I haz the power, 2016-05-12 21:56:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 21:56:50]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[Brian Osman, 2016-05-12 23:28:38]

brianosman@google.com changed reviewers:
+ brianosman@google.com

[Brian Osman, 2016-05-12 23:28:38]

https://codereview.chromium.org/1967283002/diff/20001/src/core/SkPM4fPriv.h
File src/core/SkPM4fPriv.h (right):

https://codereview.chromium.org/1967283002/diff/20001/src/core/SkPM4fPriv.h#n...
src/core/SkPM4fPriv.h:66: //   SkColor has an ordering of (b, g, r, a) if cast
to an Sk4f, so the code swizzles r and b to
Is this true? I think it's actually platform-dependent. Last time I looked at
trying to use the Sk4f conversion helpers, I realized that they were intended
for use with PMColor? Looking tat this file, it looks like to_4f_rgba may have
been added since then, and that might be what you want to use here.

[herb_g, 2016-05-13 14:38:02]

Fix benchmark.

[herb_g, 2016-05-13 14:38:16]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-13 14:38:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1967283002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1967283002/40001

[herb_g, 2016-05-13 14:55:24]

https://codereview.chromium.org/1967283002/diff/20001/src/core/SkPM4fPriv.h
File src/core/SkPM4fPriv.h (right):

https://codereview.chromium.org/1967283002/diff/20001/src/core/SkPM4fPriv.h#n...
src/core/SkPM4fPriv.h:66: //   SkColor has an ordering of (b, g, r, a) if cast
to an Sk4f, so the code swizzles r and b to
On 2016/05/12 23:28:38, Brian Osman wrote:
> Is this true? I think it's actually platform-dependent. Last time I looked at
> trying to use the Sk4f conversion helpers, I realized that they were intended
> for use with PMColor? Looking tat this file, it looks like to_4f_rgba may have
> been added since then, and that might be what you want to use here.

I think this is correct for SkColor; SkPMColor is a different story.

[Brian Osman, 2016-05-13 15:00:27]

On 2016/05/13 14:55:24, herb_g wrote:
> https://codereview.chromium.org/1967283002/diff/20001/src/core/SkPM4fPriv.h
> File src/core/SkPM4fPriv.h (right):
> 
>
https://codereview.chromium.org/1967283002/diff/20001/src/core/SkPM4fPriv.h#n...
> src/core/SkPM4fPriv.h:66: //   SkColor has an ordering of (b, g, r, a) if cast
> to an Sk4f, so the code swizzles r and b to
> On 2016/05/12 23:28:38, Brian Osman wrote:
> > Is this true? I think it's actually platform-dependent. Last time I looked
at
> > trying to use the Sk4f conversion helpers, I realized that they were
intended
> > for use with PMColor? Looking tat this file, it looks like to_4f_rgba may
have
> > been added since then, and that might be what you want to use here.
> 
> I think this is correct for SkColor; SkPMColor is a different story.

Yup. I'm going to let Florin comment on the pipeline and shader stuff, though.

[commit-bot: I haz the power, 2016-05-13 15:01:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 15:01:46]

Dry run: This issue passed the CQ dry run.

[f(malita), 2016-05-13 16:10:40]

lgtm

https://codereview.chromium.org/1967283002/diff/40001/bench/SkLinearBitmapPip...
File bench/SkLinearBitmapPipelineBench.cpp (right):

https://codereview.chromium.org/1967283002/diff/40001/bench/SkLinearBitmapPip...
bench/SkLinearBitmapPipelineBench.cpp:150: fInvert, filterQuality, fXTile,
fYTile, paintColor, srcPixmap};
Nit: s/paintColor/SK_ColorBLACK/

https://codereview.chromium.org/1967283002/diff/40001/gm/SkLinearBitmapPipeli...
File gm/SkLinearBitmapPipelineGM.cpp (right):

https://codereview.chromium.org/1967283002/diff/40001/gm/SkLinearBitmapPipeli...
gm/SkLinearBitmapPipelineGM.cpp:125: SkShader::kRepeat_TileMode,
SkShader::kRepeat_TileMode, paintColor, pmsrc};
Nit: ditto

[herb_g, 2016-05-13 16:40:47]

use black const

[herb_g, 2016-05-13 16:42:24]

https://codereview.chromium.org/1967283002/diff/40001/bench/SkLinearBitmapPip...
File bench/SkLinearBitmapPipelineBench.cpp (right):

https://codereview.chromium.org/1967283002/diff/40001/bench/SkLinearBitmapPip...
bench/SkLinearBitmapPipelineBench.cpp:150: fInvert, filterQuality, fXTile,
fYTile, paintColor, srcPixmap};
On 2016/05/13 16:10:39, f(malita) wrote:
> Nit: s/paintColor/SK_ColorBLACK/
> 

Done.

https://codereview.chromium.org/1967283002/diff/40001/gm/SkLinearBitmapPipeli...
File gm/SkLinearBitmapPipelineGM.cpp (right):

https://codereview.chromium.org/1967283002/diff/40001/gm/SkLinearBitmapPipeli...
gm/SkLinearBitmapPipelineGM.cpp:125: SkShader::kRepeat_TileMode,
SkShader::kRepeat_TileMode, paintColor, pmsrc};
On 2016/05/13 16:10:39, f(malita) wrote:
> Nit: ditto

Done.

[herb_g, 2016-05-13 16:42:36]

The CQ bit was checked by herb@google.com

[herb_g, 2016-05-13 16:42:36]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/1967283002/#ps60001
(title: "use black const")

[commit-bot: I haz the power, 2016-05-13 16:42:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1967283002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1967283002/60001

[commit-bot: I haz the power, 2016-05-13 17:04:48]

Description was changed from

==========
This has all the different source types in and working. There are many SkDiffs,
but they seem to be due to better resolution.

This seems to fix all the bugs involved with make all the images produced by the
codec to default to sRGB.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
This has all the different source types in and working. There are many SkDiffs,
but they seem to be due to better resolution.

This seems to fix all the bugs involved with make all the images produced by the
codec to default to sRGB.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/670f01f2fc88f02ec9a6f1b47af29daeadc3b301
==========

[commit-bot: I haz the power, 2016-05-13 17:04:49]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/670f01f2fc88f02ec9a6f1b47af29daeadc3b301