Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 196683003: Use new is*Element() helper functions more in editing code (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
adamk, eseidel
CC:
blink-reviews, groby+blinkspell_chromium.org
Visibility:
Public.

Description

Use new is*Element() helper functions more in editing code Use new is*Element() helpers more in editing code. This makes the code clearer and simpler. Also use the new Traversal<*Element> API when suitable. R=eseidel, adamk BUG=346095 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169281

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -134 lines) Patch
M Source/core/editing/ApplyStyleCommand.cpp View 6 chunks +10 lines, -10 lines 0 comments Download
M Source/core/editing/BreakBlockquoteCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 10 chunks +14 lines, -13 lines 0 comments Download
M Source/core/editing/DeleteSelectionCommand.cpp View 8 chunks +10 lines, -15 lines 0 comments Download
M Source/core/editing/EditingStyle.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/editing/Editor.cpp View 3 chunks +5 lines, -6 lines 0 comments Download
M Source/core/editing/FormatBlockCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/FrameSelection.cpp View 6 chunks +17 lines, -16 lines 0 comments Download
M Source/core/editing/IndentOutdentCommand.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/InsertLineBreakCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InsertListCommand.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/editing/InsertParagraphSeparatorCommand.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/MarkupAccumulator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.cpp View 9 chunks +14 lines, -14 lines 0 comments Download
M Source/core/editing/SpellChecker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/TextIterator.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/TypingCommand.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 10 chunks +17 lines, -21 lines 0 comments Download
M Source/core/editing/markup.cpp View 8 chunks +13 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 9 months ago (2014-03-14 18:39:14 UTC) #1
adamk
lgtm
6 years, 9 months ago (2014-03-14 20:52:00 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-14 20:57:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/196683003/1
6 years, 9 months ago (2014-03-14 20:57:12 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-14 21:37:57 UTC) #5
Message was sent while issue was closed. 
Change committed as 169281

Powered by Google App Engine
This is Rietveld 408576698