Source/core/editing/InsertLineBreakCommand.cpp - Issue 196683003: Use new is*Element() helper functions more in editing code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/InsertLineBreakCommand.cpp

Issue 196683003: Use new is*Element() helper functions more in editing code (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/InsertLineBreakCommand.cpp

diff --git a/Source/core/editing/InsertLineBreakCommand.cpp b/Source/core/editing/InsertLineBreakCommand.cpp

index 5270238d9484c1824f62e95d00a0d919b2ccc811..4c2699d2afa4afda2807d8f98fdda45bfb38fb21 100644

--- a/Source/core/editing/InsertLineBreakCommand.cpp

+++ b/Source/core/editing/InsertLineBreakCommand.cpp

@@ -90,7 +90,7 @@ void InsertLineBreakCommand::doApply()

// FIXME: Need to merge text nodes when inserting just after or before text.

if (isEndOfParagraph(caret) && !lineBreakExistsAtVisiblePosition(caret)) {

- bool needExtraLineBreak = !pos.deprecatedNode()->hasTagName(hrTag) && !pos.deprecatedNode()->hasTagName(tableTag);

+ bool needExtraLineBreak = !isHTMLHRElement(*pos.deprecatedNode()) && !isHTMLTableElement(*pos.deprecatedNode());

insertNodeAt(nodeToInsert.get(), pos);