Source/core/editing/EditingStyle.cpp - Issue 196683003: Use new is*Element() helper functions more in editing code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/EditingStyle.cpp

Issue 196683003: Use new is*Element() helper functions more in editing code (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/EditingStyle.cpp

diff --git a/Source/core/editing/EditingStyle.cpp b/Source/core/editing/EditingStyle.cpp

index 6a67d9d50f595b64c1eb30958a01d52b89a81285..5ab6d5b41935f1426bf8e2a75e706ed561ad1082 100644

--- a/Source/core/editing/EditingStyle.cpp

+++ b/Source/core/editing/EditingStyle.cpp

@@ -881,8 +881,9 @@ bool EditingStyle::styleIsPresentInComputedStyleOfNode(Node* node) const

bool EditingStyle::elementIsStyledSpanOrHTMLEquivalent(const HTMLElement* element)

{

+ ASSERT(element);

bool elementIsSpanOrElementEquivalent = false;

- if (element->hasTagName(HTMLNames::spanTag))

+ if (isHTMLSpanElement(*element))

elementIsSpanOrElementEquivalent = true;

else {

const Vector<OwnPtr<HTMLElementEquivalent> >& HTMLElementEquivalents = htmlElementEquivalents();

« no previous file with comments | « Source/core/editing/DeleteSelectionCommand.cpp ('k') | Source/core/editing/Editor.cpp » ('j') | no next file with comments »