Eliminate special case nvpr batch handling

Eliminate special case nvpr batch handling

Removes drawPathBatch methods from GrDrawTarget and GrDrawContext, and
integrates nvpr batches in with all the other batches.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1966763002

Committed: https://skia.googlesource.com/skia/+/193d9cf8f2280cd4f8e509c6f3af6b47cea04935

[Chris Dalton, 2016-05-10 19:04:08]

Description was changed from

==========
Eliminate special case nvpr batch handling

Removes drawPathBatch methods from GrDrawTarget and GrDrawContext, and
integrates nvpr batches in with all the other batches.

BUG=skia:
==========

to

==========
Eliminate special case nvpr batch handling

Removes drawPathBatch methods from GrDrawTarget and GrDrawContext, and
integrates nvpr batches in with all the other batches.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Chris Dalton, 2016-05-10 19:05:27]

cdalton@nvidia.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[Chris Dalton, 2016-05-10 19:05:27]

More GrUserStencilSettings goodness!

[Mark Kilgard, 2016-05-10 20:03:06]

markkilgard@gmail.com changed reviewers:
+ markkilgard@gmail.com

[Mark Kilgard, 2016-05-10 20:03:07]

LGTM

https://codereview.chromium.org/1966763002/diff/1/src/gpu/gl/GrGLPathRenderin...
File src/gpu/gl/GrGLPathRendering.cpp (right):

https://codereview.chromium.org/1966763002/diff/1/src/gpu/gl/GrGLPathRenderin...
src/gpu/gl/GrGLPathRendering.cpp:73: case GrStencilOp::kIncWrap:
good to see the change to kIncWrap; more consistent with GL_COUNT_UP_NV doing
wrapped winding number counting

[bsalomon, 2016-05-10 20:17:26]

lgtm aside from what I think is an incorrect value for the flag.

I'm glad this special handling of path batches can go away!

https://codereview.chromium.org/1966763002/diff/1/src/gpu/GrPipeline.h
File src/gpu/GrPipeline.h (right):

https://codereview.chromium.org/1966763002/diff/1/src/gpu/GrPipeline.h#newcod...
src/gpu/GrPipeline.h:201: kHasStencilClip_Flag                = 0x8
0x10?

[Chris Dalton, 2016-05-11 22:03:34]

This version addresses the comment and also removes
GrDrawTarget::installPipelineInDrawBatch. Now that paths don't have special
handling, GrDrawTarget::drawBatch was the only place using that method, so I
just combined the two.

https://codereview.chromium.org/1966763002/diff/1/src/gpu/GrPipeline.h
File src/gpu/GrPipeline.h (right):

https://codereview.chromium.org/1966763002/diff/1/src/gpu/GrPipeline.h#newcod...
src/gpu/GrPipeline.h:201: kHasStencilClip_Flag                = 0x8
On 2016/05/10 20:17:25, bsalomon wrote:
> 0x10?

Done.

[bsalomon, 2016-05-12 00:07:05]

lgtm

On 2016/05/11 22:03:34, Chris Dalton wrote:
> This version addresses the comment and also removes
> GrDrawTarget::installPipelineInDrawBatch. Now that paths don't have special
> handling, GrDrawTarget::drawBatch was the only place using that method, so I
> just combined the two.
> 
> https://codereview.chromium.org/1966763002/diff/1/src/gpu/GrPipeline.h
> File src/gpu/GrPipeline.h (right):
> 
>
https://codereview.chromium.org/1966763002/diff/1/src/gpu/GrPipeline.h#newcod...
> src/gpu/GrPipeline.h:201: kHasStencilClip_Flag                = 0x8
> On 2016/05/10 20:17:25, bsalomon wrote:
> > 0x10?
> 
> Done.

[Chris Dalton, 2016-05-12 18:29:06]

The CQ bit was checked by cdalton@nvidia.com

[Chris Dalton, 2016-05-12 18:29:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
markkilgard@gmail.com
Link to the patchset: https://codereview.chromium.org/1966763002/#ps20001
(title: "fixes")

[commit-bot: I haz the power, 2016-05-12 18:29:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1966763002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1966763002/20001

[commit-bot: I haz the power, 2016-05-12 18:52:04]

Description was changed from

==========
Eliminate special case nvpr batch handling

Removes drawPathBatch methods from GrDrawTarget and GrDrawContext, and
integrates nvpr batches in with all the other batches.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Eliminate special case nvpr batch handling

Removes drawPathBatch methods from GrDrawTarget and GrDrawContext, and
integrates nvpr batches in with all the other batches.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/193d9cf8f2280cd4f8e509c6f3af6b47cea04935
==========

[commit-bot: I haz the power, 2016-05-12 18:52:05]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/193d9cf8f2280cd4f8e509c6f3af6b47cea04935