Remove clip from GrPipelineBuilder

Remove clip from GrPipelineBuilder

This eliminates a copy and will allow us to make the GrClip class
virutal.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1966903004

Committed: https://skia.googlesource.com/skia/+/862cff30eaa16206d76d7de7594c9167375ca87e

[Chris Dalton, 2016-05-11 22:08:53]

Description was changed from

==========
Remove clip from GrPipelineBuilder

This eliminates a copy and will allow us to make the GrClip class
virutal.

BUG=skia:
==========

to

==========
Remove clip from GrPipelineBuilder

This eliminates a copy and will allow us to make the GrClip class
virutal.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Chris Dalton, 2016-05-12 20:57:24]

cdalton@nvidia.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[Chris Dalton, 2016-05-12 20:57:25]

https://codereview.chromium.org/1966903004/diff/40001/src/gpu/GrClipMaskManag...
File src/gpu/GrClipMaskManager.cpp (left):

https://codereview.chromium.org/1966903004/diff/40001/src/gpu/GrClipMaskManag...
src/gpu/GrClipMaskManager.cpp:375: add_rect_to_clip(pipelineBuilder.clip(),
*devBounds, &devBoundsClip);
This logic has been moved to GrDrawTarget.

https://codereview.chromium.org/1966903004/diff/40001/src/gpu/GrDrawTarget.cpp
File src/gpu/GrDrawTarget.cpp (right):

https://codereview.chromium.org/1966903004/diff/40001/src/gpu/GrDrawTarget.cp...
src/gpu/GrDrawTarget.cpp:262: if (args.fOpts.fOverrides.fUsePLSDstRead ||
fClipBatchToBounds) {
This is where now handle the GrClipMaskManager::fDebugClipBatchToBounds logic.

https://codereview.chromium.org/1966903004/diff/40001/src/gpu/GrDrawTarget.cp...
src/gpu/GrDrawTarget.cpp:281: return;
This should be the only real change in functionality with this patch.

[Chris Dalton, 2016-05-12 20:58:25]

Ugh, I added a few comments to patch #3 to aid in the review process, but they
didn't carry over to #4. Make sure to take a look at them.

[bsalomon, 2016-05-12 21:25:35]

lgtm

https://codereview.chromium.org/1966903004/diff/60001/src/gpu/GrDrawTarget.cpp
File src/gpu/GrDrawTarget.cpp (right):

https://codereview.chromium.org/1966903004/diff/60001/src/gpu/GrDrawTarget.cp...
src/gpu/GrDrawTarget.cpp:309: void GrDrawTarget::stencilPath(const
GrPipelineBuilder& pipelineBuilder,
Curious why we have this function anymore.. Can the batch creation logic be
moved to the caller and then have it call drawBatch()? No necessary an item for
this patch, just curious.

[Chris Dalton, 2016-05-12 21:29:19]

https://codereview.chromium.org/1966903004/diff/60001/src/gpu/GrDrawTarget.cpp
File src/gpu/GrDrawTarget.cpp (right):

https://codereview.chromium.org/1966903004/diff/60001/src/gpu/GrDrawTarget.cp...
src/gpu/GrDrawTarget.cpp:309: void GrDrawTarget::stencilPath(const
GrPipelineBuilder& pipelineBuilder,
On 2016/05/12 21:25:35, bsalomon wrote:
> Curious why we have this function anymore.. Can the batch creation logic be
> moved to the caller and then have it call drawBatch()? No necessary an item
for
> this patch, just curious.

The (current) reason is that GrStencilPathBatch doesn't have a GrPipeline (it
inherits from GrBatch and not GrDrawBatch).

drawBatch() installs a pipeline and everything.

Theoretically GrStencilPathBatch could be made to inherit from GrDrawBatch and
then use a disabled XP like many other stencil draws.

[Chris Dalton, 2016-05-12 21:47:57]

The CQ bit was checked by cdalton@nvidia.com

[commit-bot: I haz the power, 2016-05-12 21:48:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1966903004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1966903004/60001

[commit-bot: I haz the power, 2016-05-12 22:09:53]

Description was changed from

==========
Remove clip from GrPipelineBuilder

This eliminates a copy and will allow us to make the GrClip class
virutal.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Remove clip from GrPipelineBuilder

This eliminates a copy and will allow us to make the GrClip class
virutal.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/862cff30eaa16206d76d7de7594c9167375ca87e
==========

[commit-bot: I haz the power, 2016-05-12 22:09:54]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/862cff30eaa16206d76d7de7594c9167375ca87e