Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1966723002: [Offline pages] Disabling offline pages in incognito (Closed)

Created:
4 years, 7 months ago by fgorski
Modified:
4 years, 7 months ago
Reviewers:
dewittj
CC:
chromium-reviews, fgorski+watch_chromium.org, romax+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Disabling offline pages in incognito This patch simply makes sure that offline page model is no longer avaialbe in incognito mode. BUG=603940, 606313 R=dewittj@chromium.org Committed: https://crrev.com/4727ab67dde1088bdb5da8c63c51ee91e929e6e9 Cr-Commit-Position: refs/heads/master@{#392710}

Patch Set 1 #

Patch Set 2 : Adding a TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M chrome/browser/android/offline_pages/offline_page_model_factory.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_model_factory.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
fgorski
PTAL
4 years, 7 months ago (2016-05-10 18:13:30 UTC) #3
dewittj
lgtm Can we add an integration test that checks this logic from the android side? ...
4 years, 7 months ago (2016-05-10 18:19:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966723002/20001
4 years, 7 months ago (2016-05-10 20:39:48 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-10 20:54:44 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 20:57:15 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4727ab67dde1088bdb5da8c63c51ee91e929e6e9
Cr-Commit-Position: refs/heads/master@{#392710}

Powered by Google App Engine
This is Rietveld 408576698