Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Side by Side Diff: chrome/browser/android/offline_pages/offline_page_model_factory.h

Issue 1966723002: [Offline pages] Disabling offline pages in incognito (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding a TODO Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_model_factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_MODEL_FACTORY_H_ 5 #ifndef CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_MODEL_FACTORY_H_
6 #define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_MODEL_FACTORY_H_ 6 #define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_MODEL_FACTORY_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "components/keyed_service/content/browser_context_keyed_service_factory .h" 9 #include "components/keyed_service/content/browser_context_keyed_service_factory .h"
10 10
11 namespace base { 11 namespace base {
12 template <typename T> 12 template <typename T>
13 struct DefaultSingletonTraits; 13 struct DefaultSingletonTraits;
14 } // namespace base 14 } // namespace base
15 15
16 namespace offline_pages { 16 namespace offline_pages {
17 17
18 class OfflinePageModel; 18 class OfflinePageModel;
19 19
20 // A factory to create one unique OfflinePageModel. 20 // A factory to create one unique OfflinePageModel. Offline pages are not
21 // supported in incognito, and this class uses default implementation of
22 // |GetBrowserContextToUse|.
23 // TODO(fgorski): Add an integration test that ensures incognito users don't
24 // save or open offline pages.
21 class OfflinePageModelFactory : public BrowserContextKeyedServiceFactory { 25 class OfflinePageModelFactory : public BrowserContextKeyedServiceFactory {
22 public: 26 public:
23 static OfflinePageModelFactory* GetInstance(); 27 static OfflinePageModelFactory* GetInstance();
24 static OfflinePageModel* GetForBrowserContext( 28 static OfflinePageModel* GetForBrowserContext(
25 content::BrowserContext* context); 29 content::BrowserContext* context);
26 30
27 private: 31 private:
28 friend struct base::DefaultSingletonTraits<OfflinePageModelFactory>; 32 friend struct base::DefaultSingletonTraits<OfflinePageModelFactory>;
29 33
30 OfflinePageModelFactory(); 34 OfflinePageModelFactory();
31 ~OfflinePageModelFactory() override {} 35 ~OfflinePageModelFactory() override {}
32 36
33 KeyedService* BuildServiceInstanceFor( 37 KeyedService* BuildServiceInstanceFor(
34 content::BrowserContext* context) const override; 38 content::BrowserContext* context) const override;
35 39
36 content::BrowserContext* GetBrowserContextToUse(
37 content::BrowserContext* context) const override;
38
39 DISALLOW_COPY_AND_ASSIGN(OfflinePageModelFactory); 40 DISALLOW_COPY_AND_ASSIGN(OfflinePageModelFactory);
40 }; 41 };
41 42
42 } // namespace offline_pages 43 } // namespace offline_pages
43 44
44 #endif // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_MODEL_FACTORY_H_ 45 #endif // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_MODEL_FACTORY_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_model_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698