Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: chrome/browser/android/offline_pages/offline_page_model_factory.h

Issue 1966723002: [Offline pages] Disabling offline pages in incognito (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding a TODO Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_model_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/offline_page_model_factory.h
diff --git a/chrome/browser/android/offline_pages/offline_page_model_factory.h b/chrome/browser/android/offline_pages/offline_page_model_factory.h
index 25575cf0463dd571dc02bf60f31515f9e2a272da..3944e382c054303cc740c22c7131f26bc9618afb 100644
--- a/chrome/browser/android/offline_pages/offline_page_model_factory.h
+++ b/chrome/browser/android/offline_pages/offline_page_model_factory.h
@@ -17,7 +17,11 @@ namespace offline_pages {
class OfflinePageModel;
-// A factory to create one unique OfflinePageModel.
+// A factory to create one unique OfflinePageModel. Offline pages are not
+// supported in incognito, and this class uses default implementation of
+// |GetBrowserContextToUse|.
+// TODO(fgorski): Add an integration test that ensures incognito users don't
+// save or open offline pages.
class OfflinePageModelFactory : public BrowserContextKeyedServiceFactory {
public:
static OfflinePageModelFactory* GetInstance();
@@ -33,9 +37,6 @@ class OfflinePageModelFactory : public BrowserContextKeyedServiceFactory {
KeyedService* BuildServiceInstanceFor(
content::BrowserContext* context) const override;
- content::BrowserContext* GetBrowserContextToUse(
- content::BrowserContext* context) const override;
-
DISALLOW_COPY_AND_ASSIGN(OfflinePageModelFactory);
};
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_model_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698