Issue 196653015: Fixed spec violation of storing to length of a frozen object.

Issue 196653015: Fixed spec violation of storing to length of a frozen object. (Closed)

Created:
6 years, 9 months ago by Igor Sheludko

Modified:
6 years, 9 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fixed spec violation of storing to length of a frozen object. BUG=chromium:350890 LOG=N R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20005

Patch Set 2 : Review notes applied #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -303 lines)			Patch
M	src/a64/code-stubs-a64.cc	View		1 chunk	+0 lines, -71 lines	0 comments	Download
M	src/a64/stub-cache-a64.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View		1 chunk	+0 lines, -71 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/code-stubs.h	View		2 chunks	+0 lines, -12 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View		1 chunk	+0 lines, -65 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/ic.cc	View	1	2 chunks	+11 lines, -20 lines	0 comments	Download
M	src/stub-cache.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/stub-cache.cc	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View		1 chunk	+0 lines, -64 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
A	test/mjsunit/regress/regress-crbug-350890.js	View		1 chunk	+42 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

lgtm with nit https://codereview.chromium.org/196653015/diff/1/src/stub-cache.cc File src/stub-cache.cc (right): https://codereview.chromium.org/196653015/diff/1/src/stub-cache.cc#newcode1130 src/stub-cache.cc:1130: // It is not necessary to ...

6 years, 9 months ago (2014-03-17 15:12:09 UTC) #2

Igor Sheludko

https://codereview.chromium.org/196653015/diff/1/src/stub-cache.cc File src/stub-cache.cc (right): https://codereview.chromium.org/196653015/diff/1/src/stub-cache.cc#newcode1130 src/stub-cache.cc:1130: // It is not necessary to check object since ...

6 years, 9 months ago (2014-03-17 15:43:16 UTC) #3

Igor Sheludko

6 years, 9 months ago (2014-03-17 15:43:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20005 (presubmit successful).

Expand Messages | Collapse Messages