Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 196653015: Fixed spec violation of storing to length of a frozen object. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Review notes applied Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/code-stubs.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1418 matching lines...) Expand 10 before | Expand all | Expand 10 after
1429 __ bind(&miss); 1429 __ bind(&miss);
1430 TailCallBuiltin(masm(), MissBuiltin(kind())); 1430 TailCallBuiltin(masm(), MissBuiltin(kind()));
1431 1431
1432 // Return the generated code. 1432 // Return the generated code.
1433 InlineCacheState state = 1433 InlineCacheState state =
1434 number_of_handled_maps > 1 ? POLYMORPHIC : MONOMORPHIC; 1434 number_of_handled_maps > 1 ? POLYMORPHIC : MONOMORPHIC;
1435 return GetICCode(kind(), type, name, state); 1435 return GetICCode(kind(), type, name, state);
1436 } 1436 }
1437 1437
1438 1438
1439 void StoreStubCompiler::GenerateStoreArrayLength() {
1440 // Prepare tail call to StoreIC_ArrayLength.
1441 __ Push(receiver(), value());
1442
1443 ExternalReference ref =
1444 ExternalReference(IC_Utility(IC::kStoreIC_ArrayLength),
1445 masm()->isolate());
1446 __ TailCallExternalReference(ref, 2, 1);
1447 }
1448
1449
1439 Handle<Code> KeyedStoreStubCompiler::CompileStorePolymorphic( 1450 Handle<Code> KeyedStoreStubCompiler::CompileStorePolymorphic(
1440 MapHandleList* receiver_maps, 1451 MapHandleList* receiver_maps,
1441 CodeHandleList* handler_stubs, 1452 CodeHandleList* handler_stubs,
1442 MapHandleList* transitioned_maps) { 1453 MapHandleList* transitioned_maps) {
1443 Label miss; 1454 Label miss;
1444 __ JumpIfSmi(receiver(), &miss); 1455 __ JumpIfSmi(receiver(), &miss);
1445 1456
1446 int receiver_count = receiver_maps->length(); 1457 int receiver_count = receiver_maps->length();
1447 __ ldr(scratch1(), FieldMemOperand(receiver(), HeapObject::kMapOffset)); 1458 __ ldr(scratch1(), FieldMemOperand(receiver(), HeapObject::kMapOffset));
1448 for (int i = 0; i < receiver_count; ++i) { 1459 for (int i = 0; i < receiver_count; ++i) {
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
1511 // ----------------------------------- 1522 // -----------------------------------
1512 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1523 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1513 } 1524 }
1514 1525
1515 1526
1516 #undef __ 1527 #undef __
1517 1528
1518 } } // namespace v8::internal 1529 } } // namespace v8::internal
1519 1530
1520 #endif // V8_TARGET_ARCH_ARM 1531 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/code-stubs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698