Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: src/ia32/stub-cache-ia32.cc

Issue 196653015: Fixed spec violation of storing to length of a frozen object. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Review notes applied Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1256 matching lines...) Expand 10 before | Expand all | Expand 10 after
1267 // Do tail-call to the runtime system. 1267 // Do tail-call to the runtime system.
1268 ExternalReference store_ic_property = 1268 ExternalReference store_ic_property =
1269 ExternalReference(IC_Utility(IC::kStoreInterceptorProperty), isolate()); 1269 ExternalReference(IC_Utility(IC::kStoreInterceptorProperty), isolate());
1270 __ TailCallExternalReference(store_ic_property, 3, 1); 1270 __ TailCallExternalReference(store_ic_property, 3, 1);
1271 1271
1272 // Return the generated code. 1272 // Return the generated code.
1273 return GetCode(kind(), Code::FAST, name); 1273 return GetCode(kind(), Code::FAST, name);
1274 } 1274 }
1275 1275
1276 1276
1277 void StoreStubCompiler::GenerateStoreArrayLength() {
1278 // Prepare tail call to StoreIC_ArrayLength.
1279 __ pop(scratch1()); // remove the return address
1280 __ push(receiver());
1281 __ push(value());
1282 __ push(scratch1()); // restore return address
1283
1284 ExternalReference ref =
1285 ExternalReference(IC_Utility(IC::kStoreIC_ArrayLength),
1286 masm()->isolate());
1287 __ TailCallExternalReference(ref, 2, 1);
1288 }
1289
1290
1277 Handle<Code> KeyedStoreStubCompiler::CompileStorePolymorphic( 1291 Handle<Code> KeyedStoreStubCompiler::CompileStorePolymorphic(
1278 MapHandleList* receiver_maps, 1292 MapHandleList* receiver_maps,
1279 CodeHandleList* handler_stubs, 1293 CodeHandleList* handler_stubs,
1280 MapHandleList* transitioned_maps) { 1294 MapHandleList* transitioned_maps) {
1281 Label miss; 1295 Label miss;
1282 __ JumpIfSmi(receiver(), &miss, Label::kNear); 1296 __ JumpIfSmi(receiver(), &miss, Label::kNear);
1283 __ mov(scratch1(), FieldOperand(receiver(), HeapObject::kMapOffset)); 1297 __ mov(scratch1(), FieldOperand(receiver(), HeapObject::kMapOffset));
1284 for (int i = 0; i < receiver_maps->length(); ++i) { 1298 for (int i = 0; i < receiver_maps->length(); ++i) {
1285 __ cmp(scratch1(), receiver_maps->at(i)); 1299 __ cmp(scratch1(), receiver_maps->at(i));
1286 if (transitioned_maps->at(i).is_null()) { 1300 if (transitioned_maps->at(i).is_null()) {
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
1521 // ----------------------------------- 1535 // -----------------------------------
1522 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1536 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1523 } 1537 }
1524 1538
1525 1539
1526 #undef __ 1540 #undef __
1527 1541
1528 } } // namespace v8::internal 1542 } } // namespace v8::internal
1529 1543
1530 #endif // V8_TARGET_ARCH_IA32 1544 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698